Skip to content

chore: adaptations for Aesop import reduction#40217

Open
JovanGerb wants to merge 2 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-Aesop-imports
Open

chore: adaptations for Aesop import reduction#40217
JovanGerb wants to merge 2 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-Aesop-imports

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb commented Jun 4, 2026

This PR adds an import, so that mathlib can adapt to the changes in leanprover-community/aesop#330

The -0.15% benchmark result is obtained by changing the aesop version. But the current version of this PR does not do that.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR summary 1686f7fa1e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 1686f7f).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 1686f7fa1e
Reference commit 07107e4cfd

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@JovanGerb JovanGerb added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 4, 2026
@JovanGerb
Copy link
Copy Markdown
Contributor Author

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Jun 4, 2026

Benchmark results for 9e7d168 against 07107e4 are in. There are significant results. @JovanGerb

  • build//instructions: -234.2G (-0.15%)

Medium changes (13✅)

  • build/module/Aesop.Frontend.Basic//instructions: -1.1G (-48.28%) (reduced significance based on absolute threshold)
  • build/module/Aesop.Frontend.Tactic//instructions: -1.3G (-21.59%) (reduced significance based on absolute threshold)
  • build/module/Aesop.Index.DiscrTreeConfig//instructions: -1.0G (-47.44%) (reduced significance based on absolute threshold)
  • build/module/Aesop.Options.Public//instructions: -1.1G (-34.80%) (reduced significance based on absolute threshold)
  • build/module/Aesop.RuleSet.Name//instructions: -1.1G (-54.00%) (reduced significance based on absolute threshold)
  • build/module/Aesop.RuleTac.Forward//instructions: -1.4G (-16.25%) (reduced significance based on absolute threshold)
  • build/module/Aesop.Script.GoalWithMVars//instructions: -1.0G (-46.31%) (reduced significance based on absolute threshold)
  • build/module/Aesop.Script.SpecificTactics//instructions: -1.4G (-12.45%)
  • build/module/Aesop.Script.Tactic//instructions: -1.0G (-47.62%) (reduced significance based on absolute threshold)
  • build/module/Aesop.Script.TacticState//instructions: -1.1G (-35.93%) (reduced significance based on absolute threshold)
  • build/module/Aesop.Util.Basic//instructions: -1.2G (-12.22%)
  • build/module/Aesop.Util.Tactic//instructions: -1.0G (-45.57%) (reduced significance based on absolute threshold)
  • build/module/Aesop.Util.Unfold//instructions: -1.0G (-27.16%) (reduced significance based on absolute threshold)

Small changes (328✅)

Too many entries to display here. View the full report on radar instead.

@JovanGerb JovanGerb temporarily deployed to cache-upload-forks June 4, 2026 12:21 — with GitHub Actions Inactive
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 4, 2026
@JovanGerb JovanGerb added the easy < 20s of review time. See the lifecycle page for guidelines. label Jun 4, 2026
@JovanGerb JovanGerb temporarily deployed to cache-upload-forks June 4, 2026 15:25 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants