Skip to content

chore(Data/{FunLike/SetLike}): unprime coe_injective'#40215

Open
YaelDillies wants to merge 1 commit into
leanprover-community:masterfrom
YaelDillies:coe_injective
Open

chore(Data/{FunLike/SetLike}): unprime coe_injective'#40215
YaelDillies wants to merge 1 commit into
leanprover-community:masterfrom
YaelDillies:coe_injective

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

Since Coe.coe and CoeFun.coe are reducible, the primed version is unnecessary.


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 4, 2026
@Vierkantor Vierkantor self-assigned this Jun 4, 2026
@YaelDillies YaelDillies added the t-data Data (lists, quotients, numbers, etc) label Jun 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR summary 252c406d1f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance (priority := 100) : CoeFun F (fun _ ↦ ∀ a : α, β a)
++ coe_injective'
- instance (priority := 100) hasCoeToFun : CoeFun F (fun _ ↦ ∀ a : α, β a)
-- coe_injective

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 252c406d1f
Reference commit c87658adb9

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Since `Coe.coe` and `CoeFun.coe` are reducible, the primed version is unnecessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants