chore: omega to lia replacements that require unfolding min/max#40214
Draft
chenson2018 wants to merge 1 commit into
Draft
chore: omega to lia replacements that require unfolding min/max#40214chenson2018 wants to merge 1 commit into
chenson2018 wants to merge 1 commit into
Conversation
PR summary aa66269d4bImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR, as we may not want to actually take this approach. This is mostly to point out where this pattern applies.
#40015 was merged with some outstanding comments from @grunweg, asking about some replacements of
omegawithgrindmade in that PR. In general this is undesirable, as we would rather replace withliafor the purposes of more clearly communicating the intent of the proof and potential performance benefits.I noted that in the couple of cases there, all that was required to use
liawas some unfolding. I had a guess that this would be the case throughout Mathlib, and decided to check this against #nightly-testing-mathlib>nightly-testing regression log, which records all places thatomegacannot be directly replaced withlia. There are only 44 places this happens, and about 75% of them amount to usingmax_def/min_defas shown in this PR.