chore: expire delegations if later pushes touch sensitive files#40207
Open
bryangingechen wants to merge 1 commit into
Open
chore: expire delegations if later pushes touch sensitive files#40207bryangingechen wants to merge 1 commit into
bryangingechen wants to merge 1 commit into
Conversation
PR summary 3f1f3d0f24Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
|
Thanks! I'd like to have another pair of eyes on the glob patterns, but the policy seems good to me. |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Collaborator
|
This is interesting, can you please elaborate on the goal with it? Is it to protect the CI servers or other contributors who have cloned the project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
restrict_to_pathssetting per leanprover-community/bors-ng#50 so that delegated PRs will have their delegations expire immediately if the author pushes changes to any files outside the following locations:As a consequence, changes outside these directories after delegation must be re-approved by a maintainer.
(bors will do its best to distinguish from changes to the code coming from the
masterbranch so except in cases of PRs that touch a large number of files, mergingmastershould be safe, even if there are changes outside the above directories.)