[Merged by Bors] - feat: lemmas about Matrix is symmetric iff bilinear form is symmetric#40201
[Merged by Bors] - feat: lemmas about Matrix is symmetric iff bilinear form is symmetric#40201gw90 wants to merge 10 commits into
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 93894ffe7dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
|
-awaiting-author |
|
Final thing, can you move LinearMap.BilinForm.ext_basis and LinearMap.BilinForm.sum_repr_mul_repr_mul to the bilinear file (where you put the iff version)? I don't think they belong in the Hom file? (Or if you want, this can be in another PR) |
I'd rather leave this as another PR, mainly because Mathlib.LinearAlgebra.BilinearForm.Hom also lists other to-dos about re-arranging/eliminating redundant code, and I think that deserves its own PR where everything is thought out all together. |
themathqueen
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by themathqueen. |
…#40201) Adds 4 lemmas, all of which are variants of the statement that a matrix is symmetric if and only if the corresponding bilinear form is symmetric. These lemmas would help me in a downstream project. Co-authored-by: Gregory Wickham <gwickham99@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
Adds 4 lemmas, all of which are variants of the statement that a matrix is symmetric if and only if the corresponding bilinear form is symmetric. These lemmas would help me in a downstream project.