feat(FinitelyPresentedGroup): add definitional equivalence with generating set given by S : Set G#40200
feat(FinitelyPresentedGroup): add definitional equivalence with generating set given by S : Set G#40200AlecsFerra wants to merge 3 commits into
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 98200fe16eImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.GroupTheory.FinitelyPresentedGroup | 519 | 766 | +247 (+47.59%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.GroupTheory.FinitelyPresentedGroup |
247 |
Declarations diff
+ iff_hom_surj_set_G
+ of_hom_surj_finite
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
No changes to strong technical debt.
No changes to weak technical debt.
Current commit 98200fe16e
Reference commit e577c1669e
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
…ating set given by S : Set G
…nted` for free groups with a finite number of generators using `of_hom_surj_finite`
cc @homeowmorphism