Skip to content

feat(FinitelyPresentedGroup): add definitional equivalence with generating set given by S : Set G#40200

Open
AlecsFerra wants to merge 3 commits into
leanprover-community:masterfrom
AlecsFerra:master
Open

feat(FinitelyPresentedGroup): add definitional equivalence with generating set given by S : Set G#40200
AlecsFerra wants to merge 3 commits into
leanprover-community:masterfrom
AlecsFerra:master

Conversation

@AlecsFerra
Copy link
Copy Markdown

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions Bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

PR summary 98200fe16e

Import changes exceeding 2%

% File
+47.59% Mathlib.GroupTheory.FinitelyPresentedGroup

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.GroupTheory.FinitelyPresentedGroup 519 766 +247 (+47.59%)
Import changes for all files
Files Import difference
Mathlib.GroupTheory.FinitelyPresentedGroup 247

Declarations diff

+ iff_hom_surj_set_G
+ of_hom_surj_finite

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 98200fe16e
Reference commit e577c1669e

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-group-theory Group theory label Jun 3, 2026
@AlecsFerra AlecsFerra temporarily deployed to cache-upload-forks June 3, 2026 20:15 — with GitHub Actions Inactive
Comment thread Mathlib/GroupTheory/FinitelyPresentedGroup.lean Outdated
Comment thread Mathlib/GroupTheory/FinitelyPresentedGroup.lean
…nted` for free groups with a finite number of generators using `of_hom_surj_finite`
@github-actions github-actions Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 4, 2026
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 4, 2026
@AlecsFerra AlecsFerra temporarily deployed to cache-upload-forks June 4, 2026 07:53 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-group-theory Group theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants