Skip to content

feat(Algebra/Module/LocalizedModule): generalize smul'_mk#40196

Open
eric-wieser wants to merge 2 commits into
leanprover-community:masterfrom
eric-wieser:localization-smul
Open

feat(Algebra/Module/LocalizedModule): generalize smul'_mk#40196
eric-wieser wants to merge 2 commits into
leanprover-community:masterfrom
eric-wieser:localization-smul

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

This also moves it higher up the file to make clear it is unrelated to the SMul instance declared next to it.

For good measure, I add a missing SMulCommClass instance, even though I didn't need it.


Open in Gitpod

@eric-wieser eric-wieser added the easy < 20s of review time. See the lifecycle page for guidelines. label Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

PR summary ab9e995df3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : SMulCommClass T T' (LocalizedModule S M)

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit ab9e995df3
Reference commit 32610494ef

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Jun 3, 2026
@eric-wieser eric-wieser temporarily deployed to cache-upload-forks June 3, 2026 19:43 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant