Skip to content

[Merged by Bors] - chore(Algebra/Category): add ModuleCat.restrictScalarsIsoOfEquiv#37773

Closed
chrisflav wants to merge 5 commits into
leanprover-community:masterfrom
chrisflav:restrictscalars-iso-equiv
Closed

[Merged by Bors] - chore(Algebra/Category): add ModuleCat.restrictScalarsIsoOfEquiv#37773
chrisflav wants to merge 5 commits into
leanprover-community:masterfrom
chrisflav:restrictscalars-iso-equiv

Conversation

@chrisflav
Copy link
Copy Markdown
Member

@chrisflav chrisflav commented Apr 7, 2026

Extracted from #37766 as a separate PR, because it also contains three basic simp lemmas.

We also add missing type annotations in the file Mathlib/Algebra/Category/ModuleCat/ChangeOfRings.lean.


Open in Gitpod

@chrisflav chrisflav added the t-algebra Algebra (groups, rings, fields, etc) label Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

PR summary c60f516525

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ RingHom.toModule_smul
+ coe_coe_toAddEquiv_symm
+ coe_coe_toEquiv_symm
+ coe_coe_toMulEquiv_symm
+ instance {R S : Type*} [Ring R] [Ring S] (f : R →+* S) : (restrictScalars f).Additive
+ instance {R₀ R S : Type*} [CommSemiring R₀] [Ring R] [Ring S] [Algebra R₀ R] [Algebra R₀ S]
+ restrictScalarsIsoOfEquiv
+ restrictScalarsIsoOfEquiv_hom_apply
+ restrictScalarsIsoOfEquiv_inv_apply
- instance {R S} [Ring R] [Ring S] (f : R →+* S) : (restrictScalars f).Additive
- instance {R₀ R S} [CommSemiring R₀] [Ring R] [Ring S] [Algebra R₀ R] [Algebra R₀ S]

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/Algebra/Category/ModuleCat/ChangeOfRings.lean Outdated
@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 13, 2026
@chrisflav chrisflav removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 13, 2026
Copy link
Copy Markdown
Contributor

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 17, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Can you improve the PR message? You say "split off", but it's not clear what you are talking about. Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 17, 2026

✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage Bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 17, 2026
@chrisflav
Copy link
Copy Markdown
Member Author

I think I have clarified the PR description. Thanks for the reviews!
bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Apr 19, 2026
…37773)

Extracted from #37766 as a separate PR, because it also contains three basic `simp` lemmas.

We also add missing type annotations in the file `Mathlib/Algebra/Category/ModuleCat/ChangeOfRings.lean`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 19, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Algebra/Category): add ModuleCat.restrictScalarsIsoOfEquiv [Merged by Bors] - chore(Algebra/Category): add ModuleCat.restrictScalarsIsoOfEquiv Apr 19, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 19, 2026
jessealama pushed a commit to jessealama/mathlib4 that referenced this pull request May 2, 2026
…eanprover-community#37773)

Extracted from leanprover-community#37766 as a separate PR, because it also contains three basic `simp` lemmas.

We also add missing type annotations in the file `Mathlib/Algebra/Category/ModuleCat/ChangeOfRings.lean`.
gaetanserre pushed a commit to gaetanserre/mathlib4 that referenced this pull request May 5, 2026
…eanprover-community#37773)

Extracted from leanprover-community#37766 as a separate PR, because it also contains three basic `simp` lemmas.

We also add missing type annotations in the file `Mathlib/Algebra/Category/ModuleCat/ChangeOfRings.lean`.
gasparattila pushed a commit to gasparattila/mathlib4 that referenced this pull request May 9, 2026
…eanprover-community#37773)

Extracted from leanprover-community#37766 as a separate PR, because it also contains three basic `simp` lemmas.

We also add missing type annotations in the file `Mathlib/Algebra/Category/ModuleCat/ChangeOfRings.lean`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants