Skip to content

Conversation

@Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented Jan 11, 2026

From CLT.
I proved the more strong statements: map (√·) atTop = atTop and comap (√·) atTop = atTop.
While I'm at it, I added a fun_prop attr to Continuous (√·).


For reviewers: What I checked

Open in Gitpod

From [CLT](https://github.com/RemyDegenne/CLT/blob/07a49e97b1c745d306d301200a97c48eeb299205/Clt/CLT.lean#L34).
I proved the more strong statements: `map (√·) atTop = atTop` and `comap (√·) atTop = atTop`.
While I'm at it, I added a `fun_prop` attr to `Continuous (√·)`.

---

For reviewers: What I checked
* I [loogled](https://loogle.lean-lang.org/?q=Real.sqrt%2C+Filter.atTop) to make sure these lemmas are not yet in Mathlib.
* I made sure it's unnecessary to make the lemmas of `NNReal.sqrt` version because `NNReal.sqrt` is `OrderIso` and [Mathlib already has the lemma of `OrderIso` version](https://loogle.lean-lang.org/?q=OrderIso%2C+Filter.atTop).
@Komyyy Komyyy added t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order theory labels Jan 11, 2026
@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Jan 11, 2026
@github-actions
Copy link

github-actions bot commented Jan 11, 2026

PR summary 19e41d0839

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ comap_sqrt_atTop
+ map_sqrt_atTop
+ tendsto_sqrt_atTop

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Komyyy Komyyy removed the t-data Data (lists, quotients, numbers, etc) label Jan 11, 2026
@eric-wieser
Copy link
Member

bors d+

Thanks!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 11, 2026

✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser eric-wieser added the awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. label Jan 11, 2026
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 11, 2026
@github-actions github-actions bot removed the awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. label Jan 11, 2026
@Komyyy
Copy link
Collaborator Author

Komyyy commented Jan 11, 2026

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 11, 2026
From [CLT](https://github.com/RemyDegenne/CLT/blob/07a49e97b1c745d306d301200a97c48eeb299205/Clt/CLT.lean#L34).
I proved the more strong statements: `map (√·) atTop = atTop` and `comap (√·) atTop = atTop`.
While I'm at it, I added a `fun_prop` attr to `Continuous (√·)`.

Co-authored-by: Komyyy <pol_tta@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-order Order theory t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants