-
Notifications
You must be signed in to change notification settings - Fork 997
feat: Tendsto (√·) atTop atTop
#33837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Komyyy
wants to merge
3
commits into
leanprover-community:master
Choose a base branch
from
Komyyy:sqrt_at_top
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From [CLT](https://github.com/RemyDegenne/CLT/blob/07a49e97b1c745d306d301200a97c48eeb299205/Clt/CLT.lean#L34). I proved the more strong statements: `map (√·) atTop = atTop` and `comap (√·) atTop = atTop`. While I'm at it, I added a `fun_prop` attr to `Continuous (√·)`. --- For reviewers: What I checked * I [loogled](https://loogle.lean-lang.org/?q=Real.sqrt%2C+Filter.atTop) to make sure these lemmas are not yet in Mathlib. * I made sure it's unnecessary to make the lemmas of `NNReal.sqrt` version because `NNReal.sqrt` is `OrderIso` and [Mathlib already has the lemma of `OrderIso` version](https://loogle.lean-lang.org/?q=OrderIso%2C+Filter.atTop).
PR summary 19e41d0839Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
eric-wieser
reviewed
Jan 11, 2026
eric-wieser
reviewed
Jan 11, 2026
Member
|
bors d+ Thanks! |
Contributor
|
✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 11, 2026
From [CLT](https://github.com/RemyDegenne/CLT/blob/07a49e97b1c745d306d301200a97c48eeb299205/Clt/CLT.lean#L34). I proved the more strong statements: `map (√·) atTop = atTop` and `comap (√·) atTop = atTop`. While I'm at it, I added a `fun_prop` attr to `Continuous (√·)`. Co-authored-by: Komyyy <pol_tta@outlook.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
This pull request has been delegated to the PR author (or occasionally another non-maintainer).
t-order
Order theory
t-topology
Topological spaces, uniform spaces, metric spaces, filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From CLT.
I proved the more strong statements:
map (√·) atTop = atTopandcomap (√·) atTop = atTop.While I'm at it, I added a
fun_propattr toContinuous (√·).For reviewers: What I checked
NNReal.sqrtversion becauseNNReal.sqrtisOrderIsoand Mathlib already has the lemma ofOrderIsoversion.