Skip to content

[Merged by Bors] - feat(CategoryTheory/NatTrans): use to_dual #33834

Closed
JovanGerb wants to merge 11 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-to_dual-NatTrans
Closed

[Merged by Bors] - feat(CategoryTheory/NatTrans): use to_dual #33834
JovanGerb wants to merge 11 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-to_dual-NatTrans

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

This PR tags NatTrans with to_dual. The two functor arguments get swapped because the underlying NatTrans.app has its direction swapped.

Translating the naturality field is slightly awkward. We need to define a constant naturality' (analogously to `Category.assoc')


Open in Gitpod

@JovanGerb JovanGerb changed the title Jovan-to_dual-NatTrans feat(CategoryTheory/NatTrans): use to_dual Jan 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 11, 2026

PR summary 25d72f3b6b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ NatTrans.naturality'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 11, 2026

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 11, 2026
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 14, 2026
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@JovanGerb JovanGerb added the t-category-theory Category theory label Jan 16, 2026
Copy link
Copy Markdown
Contributor

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 16, 2026
@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 16, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jan 16, 2026
This PR tags `NatTrans` with `to_dual`. The two functor arguments get swapped because the underlying `NatTrans.app` has its direction swapped.

Translating the `naturality` field is slightly awkward. We need to define a constant `naturality'` (analogously to `Category.assoc')
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Jan 16, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(CategoryTheory/NatTrans): use to_dual [Merged by Bors] - feat(CategoryTheory/NatTrans): use to_dual Jan 16, 2026
@mathlib-bors mathlib-bors Bot closed this Jan 16, 2026
eliasjudin pushed a commit to eliasjudin/mathlib4 that referenced this pull request Jan 18, 2026
This PR tags `NatTrans` with `to_dual`. The two functor arguments get swapped because the underlying `NatTrans.app` has its direction swapped.

Translating the `naturality` field is slightly awkward. We need to define a constant `naturality'` (analogously to `Category.assoc')
bilichboris pushed a commit to bilichboris/mathlib4 that referenced this pull request Jan 18, 2026
This PR tags `NatTrans` with `to_dual`. The two functor arguments get swapped because the underlying `NatTrans.app` has its direction swapped.

Translating the `naturality` field is slightly awkward. We need to define a constant `naturality'` (analogously to `Category.assoc')
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
This PR tags `NatTrans` with `to_dual`. The two functor arguments get swapped because the underlying `NatTrans.app` has its direction swapped.

Translating the `naturality` field is slightly awkward. We need to define a constant `naturality'` (analogously to `Category.assoc')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants