[Merged by Bors] - Chore(Algebra/Polynomial/Module/Basic): Refactor out Module.AEval - #13613
Closed
Shamrock-Frost wants to merge 4 commits into
Closed
[Merged by Bors] - Chore(Algebra/Polynomial/Module/Basic): Refactor out Module.AEval #13613Shamrock-Frost wants to merge 4 commits into
Shamrock-Frost wants to merge 4 commits into
Conversation
Shamrock-Frost
added
awaiting-review
awaiting-CI
ghost
added
the
merge-conflict
PR summaryImport changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Shamrock-Frost
force-pushed
the
AEval-refactor
branch
from
June 7, 2024 19:07
25daabc to
1e56db2
Compare
ghost
removed
the
merge-conflict
github-actions
Bot
removed
the
awaiting-CI
erdOne
reviewed
Jun 8, 2024
Member
|
LGTM otherwise. Thanks! |
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Member
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
github-actions
Bot
added
the
maintainer-merge
ghost
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jun 8, 2024
…3613) Refactor Module.AEval out of Algebra/Polynomial/Module/Basic.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
…3613) Refactor Module.AEval out of Algebra/Polynomial/Module/Basic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Module.AEval out of Algebra/Polynomial/Module/Basic.
See #13573 for previous discussion