Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

chore(data/fintype/card): instance well_founded_of_trans_of_irrefl - #18774

Draft
vihdzp wants to merge 6 commits into
masterfrom
wf_of_so
Draft

chore(data/fintype/card): instance well_founded_of_trans_of_irrefl#18774
vihdzp wants to merge 6 commits into
masterfrom
wf_of_so

Conversation

@vihdzp

@vihdzp vihdzp commented Apr 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR does the following:

  • turn well_founded_of_trans_of_irrefl into an instance, rename to is_well_founded_of_strict_order
  • use is_strict_order α r instead of the equivalent is_trans α r + is_irrefl α r
  • remove preorder.well_founded_(lt/gt), as their instance forms can now be inferred automatically
  • golf + fix elsewhere

Open in Gitpod

@vihdzp vihdzp added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 9, 2023
@vihdzp vihdzp added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Apr 9, 2023
@vihdzp
vihdzp marked this pull request as draft April 9, 2023 15:44
@kim-em kim-em added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. too-late This PR was ready too late for inclusion in mathlib3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vihdzp @kim-em