This repository was archived by the owner on Jul 24, 2024. It is now read-only.
feat(set_theory/game/ordinal): API for casting ordinals into games - #18703
Open
vihdzp wants to merge 4 commits into
Open
feat(set_theory/game/ordinal): API for casting ordinals into games#18703vihdzp wants to merge 4 commits into
vihdzp wants to merge 4 commits into
Conversation
vihdzp
added
the
awaiting-review
vihdzp
changed the title
eric-wieser
reviewed
Mar 31, 2023
Comment on lines
+190
to
+191
| @[simp] theorem zero_to_game : to_game 0 = 0 := | ||
| quot.sound zero_to_pgame_equiv |
Member
There was a problem hiding this comment.
This should be called to_game_zero, same throughout
Collaborator
Author
There was a problem hiding this comment.
zero_to_pgame would also need to be renamed, this affects a bunch of pre-existing lemmas. I thought that for functions to_y we could use the names x_to_y?
| noncomputable def zero_to_pgame_relabelling : to_pgame 0 ≡r 0 := | ||
| relabelling.is_empty _ | ||
|
|
||
| theorem zero_to_pgame_equiv : to_pgame 0 ≈ 0 := |
Member
There was a problem hiding this comment.
Suggested change
| theorem zero_to_pgame_equiv : to_pgame 0 ≈ 0 := | |
| theorem to_pgame_zero_equiv : to_pgame 0 ≈ 0 := |
etc
eric-wieser
added
awaiting-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #14779.