feat: add versioning to api endpoints #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I have versioned /health as well to be consistent with Beacon-API |
g11tech
approved these changes
Jan 23, 2026
looks good
MegaRedHand
added a commit
to lambdaclass/ethlambda
that referenced
this pull request
Jan 26, 2026
MegaRedHand
added a commit
to lambdaclass/ethlambda
that referenced
this pull request
Jan 26, 2026
* fix: follow spec in /metrics and /health responses See https://github.com/leanEthereum/leanSpec/blob/914e09333578072c6bf02d2d405f8c13d5b55d38/src/lean_spec/subspecs/api/server.py#L36-L46 * refactor: add new routes with dummy functions * feat: use new endpoints with versioning and consistent naming See: - leanEthereum/leanSpec#323 - leanEthereum/leanSpec#325 * feat: implement the new routes * fix: make it compile with new Store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Following the discussion in #309, I believe versioning the API endpoints from the get go is beneficial long term.
🔗 Related Issues or PRs
#309
#309 (comment)
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox