Skip to content

Update compatibilty with leafo/scss 0.1.* #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolas-brousse wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update compatibilty with leafo/scss 0.1.* #7

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3925ecc
Update compatibilty with leafo/scss 0.1.*
nicolas-brousse Aug 11, 2014
cd2cfa7
Update composer.json
nicolas-brousse Aug 11, 2014
49b281e
Update README.md
nicolas-brousse Aug 11, 2014
ddf612b
Update test.php
nicolas-brousse Aug 11, 2014
017b248
Update composer.json
nicolas-brousse Aug 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ extract script if you are updating the version of Compass that is included.

<?php
require "vendor/autoload.php";

use Leafo\ScssPhp\Compiler;

$scss = new scssc();
$scss = new Compiler();
new scss_compass($scss);

echo $scss->compile('
Expand Down
4 changes: 3 additions & 1 deletion compass.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
<?php

use Leafo\ScssPhp\Compiler;

class scss_compass {
protected $libFunctions = array("lib_compact");

static public $true = array("keyword", "true");
static public $false = array("keyword", "false");

public function __construct($scss) {
public function __construct(Compiler $scss) {
$this->scss = $scss;
$this->updateImportPath();
$this->registerFunctions();
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Compass for scssphp",
"homepage": "http://leafo.net/scssphp/",
"require": {
"leafo/scssphp": "dev-master"
"leafo/scssphp": "0.1.*"
Copy link
Copy Markdown

@artem-frolov artem-frolov Aug 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it will be better to set the version like this: >=0.1 because scssphp-compass doesn't receive updates often.
This way it will be possible to use scssphp-compass with newer versions of scssphp even if scssphp-compass will be completely abandoned (if it's not yet).

Copy link
Copy Markdown
Author

@nicolas-brousse nicolas-brousse Aug 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point :)

},
"authors": [
{
Expand Down
4 changes: 3 additions & 1 deletion test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
require "vendor/autoload.php";
require "compass.inc.php";

$scss = new scssc();
use Leafo\ScssPhp\Compiler;

$scss = new Compiler();
new scss_compass($scss);

echo $scss->compile('
Expand Down