Conversation
someaddons
approved these changes
Feb 24, 2026
uecasm
reviewed
Feb 25, 2026
| handlerCache.clear(); | ||
| synchronized (handlers) | ||
| { | ||
| handlers.add(1, handler); |
Contributor
There was a problem hiding this comment.
I realise you didn't change this, but why is this 1 rather than 0?
Contributor
There was a problem hiding this comment.
I guess that the AirPlacementHandler should be able to be overridden by adding a new placement handler
Contributor
Author
There was a problem hiding this comment.
It was for performance reasons, most common ones first.
uecasm
reviewed
Feb 25, 2026
Comment on lines
+117
to
+122
| case BEFORE: | ||
| handlers.add(i - 1, handler); | ||
| break; | ||
| case AFTER: | ||
| handlers.add(i, handler); | ||
| break; |
Contributor
There was a problem hiding this comment.
This is incorrect; BEFORE should be i and AFTER should be i + 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Closes #
Changes proposed in this pull request
Testing
Review please