Skip to content

Fix placement handlers block placement invocation#800

Merged
Raycoms merged 8 commits intoversion/1.21from
fix/placement_handlers
Feb 23, 2026
Merged

Fix placement handlers block placement invocation#800
Raycoms merged 8 commits intoversion/1.21from
fix/placement_handlers

Conversation

@Thodor12
Copy link
Contributor

Closes ldtteam/minecolonies#11337

Changes proposed in this pull request

  • Update placement handlers to call the correct block placement methods, in every scenario
  • Simplified logic by introducing utility methods for placing blocks, even including tile entities where necessary

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

Copy link
Contributor

@Raycoms Raycoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please paste a lot of buildings of different styles in the two pasting modes to see everything still works fine.

@Raycoms Raycoms deleted the branch version/1.21 January 5, 2026 14:23
@Raycoms Raycoms closed this Jan 5, 2026
@Thodor12 Thodor12 reopened this Jan 15, 2026
@Raycoms
Copy link
Contributor

Raycoms commented Feb 23, 2026

@Thodor12 conflicts

handleTileEntityPlacement(tileEntityData, world, pos.relative(facing.getOpposite()), placementContext.getRotationMirror());
}
return ActionProcessingResult.SUCCESS;
return simplePlacement(world, pos, blockState, placementContext.getRotationMirror(), tileEntityData);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for beds, just one, not both

@Raycoms Raycoms merged commit 440a07e into version/1.21 Feb 23, 2026
5 checks passed
@Raycoms Raycoms deleted the fix/placement_handlers branch February 23, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants