feat: Add reusable BottomSheet component#1653
Conversation
Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a new mobile-friendly BottomSheet component that slides up from the bottom of the screen. The feedback recommends exposing the close button's aria-label as a configurable prop (closeButtonAriaLabel) instead of hardcoding the string 'Close' to support internationalization (i18n) and localization.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
There was a problem hiding this comment.
Goooooood work here. 🥇 Let's reinforce this work and make it super solid, defined once, reused everywhere by ensuring:
- no deviances in its use should be necessary; no maintenance need in BottomSheet or in the components that use it. This should be a one-time effort. For example, given its use in the display of mui-datatable column checkboxes or mui-datatable filter choices, the instances of those mui-datatables should not need to wire up to the BottomSheet - this shall be dynamic; neither component should require no consideration on an ongoing basis in either BottomSheet or in mui-datatables.
- How does this compare to what we have in meshery-cloud on the /catalog page?
- Is there an open issue to migrate that implementation to a centralized component?
- What learnings are being taken from the component in meshery-cloud?
- In what ways is this the best possible version of a "BottomSheet" component? Were are our examples of mui-datatables using this component to display filters?
- Is there an open issue to centrally and pervasively incorporate this BottomSheet component into use of each and every mui-dtatatable and to have code written once-only that defines when to activate and deactivate the BottomSheet (so the mobile experience is simply implicit)?
Answer here and/or link to each of the GH issues that you open in response to these items. Don't merge this unless my requirements above are being met.
|
@leecalcote @aabidsofi19
Conclusion
|
|
Consider using the same approach used for other components. |
|
Thanks @leecalcote for your suggestion. I found that we can also use the If you think we should go ahead with Screen.Recording.2026-06-25.at.12.23.30.PM.mov |
|
@KhushamBansal Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |


Notes for Reviewers
This PR fixes #
Screen.Recording.2026-06-23.at.1.38.19.PM.mov
Signed commits