Skip to content

Fix Error 153 in Cloud Native Playground YouTube embed #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PARTH-TUSSLE wants to merge 5 commits into
base: master
Choose a base branch
from
+34 −11
Open

Fix Error 153 in Cloud Native Playground YouTube embed #1651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1db0ea3
Fix Error 153 in Cloud Native Playground YouTube embed
PARTH-TUSSLE Jun 20, 2026
00000e2
Update src/custom/DashboardWidgets/GettingStartedWidget/JourneyModal.tsx
PARTH-TUSSLE Jun 20, 2026
d35cd82
Add loading=lazy to the video iframe
PARTH-TUSSLE Jun 21, 2026
bf82887
Revert the suggestion for video src fallback
PARTH-TUSSLE Jun 22, 2026
dcc4f5c
fix: gracefully handle youtube embed errors in JourneyModal
PARTH-TUSSLE Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/custom/DashboardWidgets/GettingStartedWidget/GetStartedModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export interface JourneyStep {
content: React.ReactNode;
image?: string;
videoSrc?: string;
video?: boolean;
video?: string;
embed?: boolean;
previousButton?: boolean;
isFullScreenModeAllowed?: boolean;
Expand Down
43 changes: 33 additions & 10 deletions src/custom/DashboardWidgets/GettingStartedWidget/JourneyModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import MesheryDesignEmbedUmd from '@layer5/meshery-design-embed';
import _ from 'lodash';
import { useEffect, useState } from 'react';
import { Link, Box } from '@mui/material';
import { styled } from '../../../theme';
import { JourneyStep, ProfileData, StepData } from './GetStartedModal';
import ReusableModal from './ReusableModal';
Expand Down Expand Up @@ -38,6 +39,23 @@ export const ModalVideo = styled('video')(() => ({
paddingBlock: '1rem'
}));

const FallbackLink: React.FC<{ video: string }> = ({ video }) => {
const watchLink = video.replace('/embed/', '/watch?v=');
return (
<Box sx={{ textAlign: 'center', my: 2 }}>
<Link
href={watchLink}
target="_blank"
rel="noopener noreferrer"
underline="hover"
sx={{ fontWeight: 'bold' }}
>
▶ Having trouble viewing? Watch on YouTube
</Link>
</Box>
);
};

const JourneyModal: React.FC<JourneyModalProps> = ({
open,
handleClose,
Expand Down Expand Up @@ -147,16 +165,21 @@ const JourneyModal: React.FC<JourneyModalProps> = ({
''
)}
{data.video !== undefined ? (
<iframe
style={{
aspectRatio: '16/9',
width: '100%'
}}
src="https://www.youtube.com/embed/Do7htKrRzDA?si=5iMQ5a1JUf3qpIiH"
title="YouTube video player"
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share"
allowFullScreen={true}
></iframe>
<div>
<iframe
style={{
aspectRatio: '16/9',
width: '100%'
}}
src={data.video}
title="YouTube video player"
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share"
allowFullScreen={true}
referrerPolicy="strict-origin-when-cross-origin"
loading="lazy"
></iframe>
<FallbackLink video={data.video} />
</div>
) : (
''
)}
Expand Down
Loading