fix(useRoomActivity): canonicalize provider_url → providerUrl#1484
Merged
leecalcote merged 1 commit intomasterfrom May 6, 2026
Merged
fix(useRoomActivity): canonicalize provider_url → providerUrl#1484leecalcote merged 1 commit intomasterfrom
leecalcote merged 1 commit intomasterfrom
Conversation
BREAKING — public hook parameter rename. Per the cluster-wide
identifier-naming contract (`meshery/schemas/AGENTS.md` row 7:
TypeScript property is camelCase), the `useRoomActivity` hook's
`provider_url` parameter and the `getCollaborationConfig` helper's
matching field were the last surviving snake_case props on the
sistent public surface. Flipping them in lockstep with downstream
callers.
Affected exported surfaces
- `UseRoomActivityParams.provider_url` → `providerUrl`
- `CollaborationConfigParams.provider_url` → `providerUrl`
Internal renames (no public-API impact):
- function-arg / local-var renames in `subscribeToRoomActivity` and
`useRoomActivity` to match the public field name (no camelCase
destructuring rename gymnastics).
Downstream coordination
This rename is a breaking change. Known downstream consumer:
`layer5labs/meshery-extensions` — `ExpandedDesignerDrawer` calls
`useRoomActivity({ provider_url: ... })` against the snake form.
That call was kept on snake post the §21 deferred-slice work in
`meshery-extensions#4228` precisely because this hook still exposed
the snake parameter name. The plan §21.A documented this as the
trailing follow-up. The companion meshery-extensions commit that
flips the outer key needs to ride in the same sistent release
window — it's a one-line `provider_url: providerUrl` rename in
that file.
Verified
- jest — 29/29 tests pass.
References
- meshery/schemas/docs/identifier-naming-migration.md §21.A (this
PR is the "sistent useRoomActivity" line item).
- layer5labs/meshery-extensions#4228 (kept the call-site outer key
on snake pending this rename).
Signed-off-by: Yi Nuo <218099172+yi-nuo426@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the useRoomActivity hook and its associated interfaces and functions by renaming the provider_url property to providerUrl to align with camelCase naming conventions. I have no feedback to provide as there were no review comments to evaluate.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the public API of the useRoomActivity hook (and related exported config helper) to use canonical camelCase naming by renaming the last remaining snake_case parameter provider_url to providerUrl, aligning the hook’s consumer-facing surface with the broader identifier-naming contract.
Changes:
- Rename
UseRoomActivityParams.provider_url→providerUrl. - Rename
CollaborationConfigParams.provider_url→providerUrland propagate throughgetCollaborationConfig. - Update internal argument/variable usage and the
useEffectdependency array to the new name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING — public hook parameter rename. The last surviving snake_case prop on sistent's public surface flipped to canonical camelCase per the cluster-wide identifier-naming contract (`meshery/schemas/AGENTS.md`, row 7: TypeScript property is camelCase).
Affected exported surfaces
Internal renames (no public-API impact):
Downstream coordination
Known downstream consumer:
The companion meshery-extensions commit that flips the outer key (
provider_url:→providerUrl:) is a one-line rename. It needs to ride in the same release window as this PR — i.e., when this Sistent change ships, the next sistent bump in `layer5labs/meshery-extensions` should land the call-site flip.Test plan
References