Skip to content

fix(useRoomActivity): canonicalize provider_url → providerUrl#1484

Merged
leecalcote merged 1 commit intomasterfrom
fix/useRoomActivity-providerUrl-canonical
May 6, 2026
Merged

fix(useRoomActivity): canonicalize provider_url → providerUrl#1484
leecalcote merged 1 commit intomasterfrom
fix/useRoomActivity-providerUrl-canonical

Conversation

@leecalcote
Copy link
Copy Markdown
Member

Summary

BREAKING — public hook parameter rename. The last surviving snake_case prop on sistent's public surface flipped to canonical camelCase per the cluster-wide identifier-naming contract (`meshery/schemas/AGENTS.md`, row 7: TypeScript property is camelCase).

Affected exported surfaces

  • `UseRoomActivityParams.provider_url` → `providerUrl`
  • `CollaborationConfigParams.provider_url` → `providerUrl`

Internal renames (no public-API impact):

  • Function arg / local var renames in `subscribeToRoomActivity` and `useRoomActivity` to match the public field name. No destructuring rename gymnastics.

Downstream coordination

Known downstream consumer:

  • `layer5labs/meshery-extensions#4228` — `ExpandedDesignerDrawer` calls `useRoomActivity({ provider_url: ... })` against the snake form. That call was kept on snake during the §21 deferred-slice work precisely because this hook still exposed the snake parameter.

The companion meshery-extensions commit that flips the outer key (provider_url:providerUrl:) is a one-line rename. It needs to ride in the same release window as this PR — i.e., when this Sistent change ships, the next sistent bump in `layer5labs/meshery-extensions` should land the call-site flip.

Test plan

  • `jest` — 29/29 tests pass.
  • After merge: bump `@sistent/sistent` in `layer5labs/meshery-extensions` and confirm the call site at `ExpandedDesignerDrawer/index.tsx` is updated to use `providerUrl:` (otherwise `useRoomActivity` won't receive the URL and the collab signaling URL will be empty).
  • After merge: bump `@sistent/sistent` in `layer5io/meshery-cloud` if any consumer there uses `useRoomActivity` (none currently — verified via grep, the cloud UI doesn't import this hook).

References

BREAKING — public hook parameter rename. Per the cluster-wide
identifier-naming contract (`meshery/schemas/AGENTS.md` row 7:
TypeScript property is camelCase), the `useRoomActivity` hook's
`provider_url` parameter and the `getCollaborationConfig` helper's
matching field were the last surviving snake_case props on the
sistent public surface. Flipping them in lockstep with downstream
callers.

Affected exported surfaces
- `UseRoomActivityParams.provider_url` → `providerUrl`
- `CollaborationConfigParams.provider_url` → `providerUrl`

Internal renames (no public-API impact):
- function-arg / local-var renames in `subscribeToRoomActivity` and
  `useRoomActivity` to match the public field name (no camelCase
  destructuring rename gymnastics).

Downstream coordination
This rename is a breaking change. Known downstream consumer:
`layer5labs/meshery-extensions` — `ExpandedDesignerDrawer` calls
`useRoomActivity({ provider_url: ... })` against the snake form.
That call was kept on snake post the §21 deferred-slice work in
`meshery-extensions#4228` precisely because this hook still exposed
the snake parameter name. The plan §21.A documented this as the
trailing follow-up. The companion meshery-extensions commit that
flips the outer key needs to ride in the same sistent release
window — it's a one-line `provider_url: providerUrl` rename in
that file.

Verified
- jest — 29/29 tests pass.

References
- meshery/schemas/docs/identifier-naming-migration.md §21.A (this
  PR is the "sistent useRoomActivity" line item).
- layer5labs/meshery-extensions#4228 (kept the call-site outer key
  on snake pending this rename).

Signed-off-by: Yi Nuo <218099172+yi-nuo426@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 6, 2026 04:35
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the useRoomActivity hook and its associated interfaces and functions by renaming the provider_url property to providerUrl to align with camelCase naming conventions. I have no feedback to provide as there were no review comments to evaluate.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the public API of the useRoomActivity hook (and related exported config helper) to use canonical camelCase naming by renaming the last remaining snake_case parameter provider_url to providerUrl, aligning the hook’s consumer-facing surface with the broader identifier-naming contract.

Changes:

  • Rename UseRoomActivityParams.provider_urlproviderUrl.
  • Rename CollaborationConfigParams.provider_urlproviderUrl and propagate through getCollaborationConfig.
  • Update internal argument/variable usage and the useEffect dependency array to the new name.

@leecalcote leecalcote merged commit 8fd9584 into master May 6, 2026
9 checks passed
@leecalcote leecalcote deleted the fix/useRoomActivity-providerUrl-canonical branch May 6, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants