fix: rename red palette to magenta and add true red palette#1189
Conversation
|
@Rajesh-Nagarajan-11 @leecalcote @nebula-aac , I request a review. |
|
@saurabhraghuvanshii ,
The magenta palette now uses true purple-pink colors instead of rose-red. The |
|
@jeetburman check shades here https://maketintsandshades.com/#colors=B32700&hashtag=0&steps=10 and issue is to rename exitsing shades without removing old shades because we are using that shades everywhere so it will break our current setup |
I understand. Thank you for clarifying. I will make the necessary changes.. |
|
@jeetburman I would suggest leave this issue solve other open issue. Because minor change can break many websites |
|
If you still trying to solve you have to go with all meshery and layer5 repo to verify your changes |
|
@jeetburman |
I have added my discussion topic in the agenda items... |
|
ack, reviewing now |
937e6b8 to
6600081
Compare
|
I have freshly made the changes this time. I preserved the original red pallette and add two new pallettes... Magenta and Crimson. @saurabhraghuvanshii @nebula-aac , let me know if any further change is required. |
- Add true magenta palette (purple-pink) with base color #E600AC - Add crimson palette (pure red) with base color #F91313 - Preserve existing red palette for backward compatibility - Export both new palettes in colors index Closes layer5io#602 Signed-off-by: Jeet Burman <jeetburrman@gmail.com>
1ac2491 to
6d7a97c
Compare
|
@jeetburman lgtm!! |
This PR addresses issue #602 by renaming the existing red palette to magenta and introducing a new true red palette.
Resolves #602
Notes for Reviewers
This PR fixes #602
The existing
redpalette contained pinkish-magenta hues (e.g.,#ff385c,#FFB3B9). This has been renamed tomagentafor semantic accuracy. A newredpalette has been created using#F91313as the base color, which is already used for notification errors and provides true red colors.Changes are backward compatible - the magenta palette retains all the previous red values, and components using error states now benefit from more accurate red colors.
Signed commits