fix: align INR formatPrice multiplier with declared rate#7825
Open
Harishrs2006 wants to merge 1 commit into
Open
fix: align INR formatPrice multiplier with declared rate#7825Harishrs2006 wants to merge 1 commit into
Harishrs2006 wants to merge 1 commit into
Conversation
The INR entry declares rate: 88.32 but formatPrice() hardcoded price * 88, causing all INR prices to be undervalued by ~0.36%. EUR correctly uses price * 0.86 matching its declared rate. This brings INR into the same pattern. Signed-off-by: Harish R S <harishrs21082006@gmail.com>
Harishrs2006
force-pushed
the
fix/inr-currency-rate-mismatch
branch
from
5dacae3 to
8640a54
Compare
Contributor
|
Preview deployment for PR #7825 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
Contributor
|
@Harishrs2006 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #7824
The
INRcurrency entry declaresrate: 88.32butformatPrice()hardcodedprice * 88, causing all INR prices to display ~0.36% lower than they should.formatSliderPrice()already usedprice * ratecorrectly. This bringsformatPrice()into the same pattern, consistent with how EUR handles it.Change:
src/utils/currencies.jsline 36:price * 88-price * 88.32