Skip to content

[Pricing] fix: currency dropdown label overlap on initial load#7823

Open
akshatsinghai6682-sketch wants to merge 4 commits into
layer5io:masterfrom
akshatsinghai6682-sketch:fix/currency-dropdown-overlap
Open

[Pricing] fix: currency dropdown label overlap on initial load#7823
akshatsinghai6682-sketch wants to merge 4 commits into
layer5io:masterfrom
akshatsinghai6682-sketch:fix/currency-dropdown-overlap

Conversation

@akshatsinghai6682-sketch

@akshatsinghai6682-sketch akshatsinghai6682-sketch commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description
This PR fixes #7822

On initial load, the currency dropdown label overlaps with the selected value due to MUI's label positioning logic not recognizing the initial value with renderValue.

Fixed by adding shrink prop to InputLabel and notched prop to Select — this keeps the label always in the top position and cuts the notch in the border correctly, preventing any overlap on initial render.

Notes for Reviewers

  • Only src/sections/Pricing/index.js changed
  • Added shrink to InputLabel and notched to Select
  • No visual change after initial load — only fixes flash/overlap on first render
  • This is the recommended MUI fix for this specific issue
    Demo
Screen.Recording.2026-06-25.at.11.56.01.AM.mov

Signed commits

  • Yes, I signed my commits.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://layer5.io/pr-preview/pr-7823/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

@akshatsinghai6682-sketch

Copy link
Copy Markdown
Contributor Author

Hi maintainers I've fixed the currency dropdown overlap issue

Fix applied:

  • Added shrink to InputLabel to keep label always at top
  • Added notched to Select to prevent overlap on initial render
  • Added legend maxWidth: 100% to fix border crossing

Preview looks good — no more overlap on reload! Please review when you get a chance

@NSTKrishna

Copy link
Copy Markdown
Contributor
Screenshot 2026-06-25 at 12 24 50 PM

change border color to white to maintain the consistency

@akshatsinghai6682-sketch

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-06-25 at 12 24 50 PM change border color to white to maintain the consistency

separate pr for that or in this only?

@NSTKrishna

Copy link
Copy Markdown
Contributor

no need of separate pr

@akshatsinghai6682-sketch

Copy link
Copy Markdown
Contributor Author

no need of separate pr

ok

@akshatsinghai6682-sketch

akshatsinghai6682-sketch commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-06-25 at 12 24 50 PM change border color to white to maintain the consistency

changed border color to white done successfully
Screenshot 2026-06-25 at 1 15 27 PM

Comment thread src/sections/Pricing/index.js Outdated
@Bhumikagarggg

Copy link
Copy Markdown
Contributor

@akshatsinghai6682-sketch Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

…n initial load

Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
@akshatsinghai6682-sketch akshatsinghai6682-sketch force-pushed the fix/currency-dropdown-overlap branch from f99912a to 6ff4209 Compare June 28, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: currency dropdown text overlapping on initial load in pricing section

4 participants