[Pricing] fix: currency dropdown label overlap on initial load#7823
Open
akshatsinghai6682-sketch wants to merge 4 commits into
Open
[Pricing] fix: currency dropdown label overlap on initial load#7823akshatsinghai6682-sketch wants to merge 4 commits into
akshatsinghai6682-sketch wants to merge 4 commits into
Conversation
Contributor
|
🚀 Preview deployment: https://layer5.io/pr-preview/pr-7823/
|
Contributor
Author
|
Hi maintainers I've fixed the currency dropdown overlap issue Fix applied:
Preview looks good — no more overlap on reload! Please review when you get a chance |
Contributor
Contributor
Author
Contributor
|
no need of separate pr |
Contributor
Author
ok |
Contributor
Author
leecalcote
requested changes
Jun 25, 2026
Contributor
|
@akshatsinghai6682-sketch Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
2070cd4 to
f008507
Compare
f008507 to
f99912a
Compare
…n initial load Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
f99912a to
6ff4209
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
This PR fixes #7822
On initial load, the currency dropdown label overlaps with the selected value due to MUI's label positioning logic not recognizing the initial value with
renderValue.Fixed by adding
shrinkprop toInputLabelandnotchedprop toSelect— this keeps the label always in the top position and cuts the notch in the border correctly, preventing any overlap on initial render.Notes for Reviewers
src/sections/Pricing/index.jschangedshrinktoInputLabelandnotchedtoSelectDemo
Screen.Recording.2026-06-25.at.11.56.01.AM.mov
Signed commits