feat: implement responsive canvas schemas card component#7805
feat: implement responsive canvas schemas card component#7805Joiejoie1 wants to merge 2 commits into
Conversation
|
Preview deployment for PR #7805 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
|
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
Bhumikagarggg
left a comment
Bhumikagarggg
left a comment
There was a problem hiding this comment.
@Joiejoie1 Could you please share the page where these changes were made? I'd like to review them in context.
|
@Joiejoie1 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Sre I will @Bhumikagarggg . Thanks |
| @@ -0,0 +1,65 @@ | |||
| import React from "react"; | |||
|
|
|||
| export const MesherySchemasCard = ({ | |||
There was a problem hiding this comment.
The onActionClick prop is passed to MesherySchemasCard, but it is not used inside the component. As a result, clicking the Manage button does not trigger any action. Could you please check and wire the prop to the button if it is intended to be functional?
Also, the PR is currently missing the required DCO sign-off.
There was a problem hiding this comment.
Hi @Sbragul26, thank you for the catch and the review!
onActionClick Prop: That was an oversight on my part. I will wire the onActionClick prop directly to the onClick handler of the "Manage" button right away so that it triggers the intended action successfully.
DCO Sign-off: Ah, it looks like my previous amend didn't fully propagate or a new commit pushed without the flag. I will re-verify my GPG/SSH environment settings in the workspace, sign the commit properly using git commit --amend -S --no-edit, and force-push it to clear the DCO check.
I'll push the updates shortly!
There was a problem hiding this comment.
Hi @Sbragul26 ,
I have updated the component to wire the onActionClick prop directly to the "Manage" button. I also amended the commit with the proper -s flag to append the required DCO sign-off. Everything should be clean and ready for another look. Thanks for the review!
Signed-off-by: GitHub <noreply@github.com>
Joiejoie1
force-pushed
the
feat/animated-card-6521
branch
from
596b781 to
ce45aea
Compare
|
@Joiejoie1 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
3 participants
Description
This PR fixes #6521 by implementing a responsive, animated
MesherySchemasCardcomponent and integrating it directly into the Kanvas/Features section layout (DesignerFeatures_diagram.js).Key additions and refactors include:
@keyframes) for UI tables, data streams, and hubs using inline CSS layers that are light on performance.DesignerFeatures_diagram.jsfrom SVGR named imports (ReactComponent) to standard source strings (<img>tags) to resolve Webpack runtime compilation failures and silent pipeline terminations.m-glass) with strict max-width constraints to ensure seamless container scaling from mobile up to desktop configurations.This PR fixes #
Notes for Reviewers
src/components/MesherySchemasCard.jsfor clean reusability.useEffectunmount return block (cancelAnimationFrameand event listener removal) to completely avoid memory leaks.Signed commits