fix(integrations): reduce excessive bottom space in honeycomb grid (#7511)#7514
Open
LeC-D wants to merge 1 commit intolayer5io:masterfrom
Open
fix(integrations): reduce excessive bottom space in honeycomb grid (#7511)#7514LeC-D wants to merge 1 commit intolayer5io:masterfrom
LeC-D wants to merge 1 commit intolayer5io:masterfrom
Conversation
…ayer5io#7511) The HoneycombGrid ul element had an extra 46px added to its explicit height (calc(height + 46px)). Since the height is already calculated precisely in Honeycomb.js based on hexagon row counts, this 46px surplus was creating empty vertical space below the last row of integrations on the /integrations page. Reduced from +46px to +3px (matching the margin value applied to each li element) to eliminate the visual gap while preserving the small buffer needed for the bottom row's top margin. Signed-off-by: Léo (LeC-D) <leo.openc@gmail.com>
Member
|
🚀 Preview for commit 7f2c791 at: https://69b70095afd869ed4bdb8a68--layer5.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7511
The integrations page (/cloud-native-management/meshery/integrations) shows a large empty space below the last row of integration hexagons.
Root Cause
In
Honeycomb.style.js, theulelement's explicit height is computed as:The
$heightvalue is already calculated precisely inHoneycomb.jsbased on the number of hexagon rows (e.g.pairsCount * 272 + 130). The extra+ 46pxwas adding ~43px of unnecessary empty space below the last row.Fix
Reduced the buffer from
46pxto3px— matching themarginapplied to eachlielement — to preserve the small visual buffer needed for the bottom row while eliminating the large gap.Testing
150px * 1.1547 ≈ 173px, negative margin≈ -40px, net ≈ 136px/row — consistent with272pxper pair used inHoneycomb.js, confirming the explicit height needs no additional large buffer.