[Navigation] fix: remove invalid alt attribute from button element#7505
Open
Daniel-1600 wants to merge 4 commits intolayer5io:masterfrom
Open
[Navigation] fix: remove invalid alt attribute from button element#7505Daniel-1600 wants to merge 4 commits intolayer5io:masterfrom
Daniel-1600 wants to merge 4 commits intolayer5io:masterfrom
Conversation
Signed-off-by: Daniel Chege <chegedan699@gmail.com>
Member
|
🚀 Preview for commit 80ce334 at: https://69b44f5d02326637424d2f3e--layer5.netlify.app |
Member
|
🚀 Preview for commit 5a4a080 at: https://69b6fefd7678234057f42a7a--layer5.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7485
Removed invalid
altattribute from the "Get Started" button in the Navigation component.The
altattribute is exclusively for images and is not valid on<button>elements.The button already uses
aria-labelandtitlefor accessibility.Notes for Reviewers
Removed
alt="Signup for Layer5 Cloud"from the button withid="get-started-2"in:src/sections/General/Navigation/index.jsSigned commits