fix(ci): correct misleading check-deps message for hugo binary - #1212
fix(ci): correct misleading check-deps message for hugo binary#1212RounakKumarAgarwal wants to merge 1 commit into
Conversation
The check-deps target verifies the npm-packaged hugo binary in node_modules/.bin, not a system-installed local hugo binary. Update the echo message to accurately reflect this. Fixes layer5io#1211 Signed-off-by: Rounak Agarwal <agarwalrounak2005@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesDependency message
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized documentation-only wording change in the Makefile with no behavior impact; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What this PR does
Fixes the misleading echo message in the
check-depsMakefile target.The message previously said:
This is misleading — the actual check verifies the npm-packaged Hugo
binary at
node_modules/.bin/hugo(installed viamake setup), not asystem-wide/local Hugo installation. The wording made it sound like a
system Hugo binary was still required, which is no longer the case.
Change
Updated the echo message to:
No logic was changed — only the message text.
Note for maintainers
This Makefile is a shared template mirrored across:
layer5io/docsmeshery/meshery/docsThe same misleading line may exist in the other repos' Makefiles. Happy
to open matching PRs there if desired, but leaving that decision to
maintainers since the comment block notes check-deps guards are
expected to differ per-repo.
Fixes #1211
Summary by CodeRabbit