Skip to content

fix(ci): correct misleading check-deps message for hugo binary - #1212

Open
RounakKumarAgarwal wants to merge 1 commit into
layer5io:masterfrom
RounakKumarAgarwal:fix/check-deps-message
Open

fix(ci): correct misleading check-deps message for hugo binary#1212
RounakKumarAgarwal wants to merge 1 commit into
layer5io:masterfrom
RounakKumarAgarwal:fix/check-deps-message

Conversation

@RounakKumarAgarwal

@RounakKumarAgarwal RounakKumarAgarwal commented Aug 20, 2026

Copy link
Copy Markdown

What this PR does

Fixes the misleading echo message in the check-deps Makefile target.

The message previously said:

Checking if 'npm' and local 'hugo' binary are present...

This is misleading — the actual check verifies the npm-packaged Hugo
binary at node_modules/.bin/hugo (installed via make setup), not a
system-wide/local Hugo installation. The wording made it sound like a
system Hugo binary was still required, which is no longer the case.

Change

Updated the echo message to:

Checking if 'npm' is installed and the npm-packaged 'hugo' binary is present...

No logic was changed — only the message text.

Note for maintainers

This Makefile is a shared template mirrored across:

  • layer5io/docs
  • meshery/meshery/docs
  • meshery-academy

The same misleading line may exist in the other repos' Makefiles. Happy
to open matching PRs there if desired, but leaving that decision to
maintainers since the comment block notes check-deps guards are
expected to differ per-repo.

Fixes #1211

Summary by CodeRabbit

  • Documentation
    • Updated the dependency check status message to clarify that Hugo is provided as an npm-packaged binary.
    • Dependency validation behavior remains unchanged.

The check-deps target verifies the npm-packaged hugo binary in
node_modules/.bin, not a system-installed local hugo binary. Update
the echo message to accurately reflect this.

Fixes layer5io#1211

Signed-off-by: Rounak Agarwal <agarwalrounak2005@gmail.com>
@welcome

welcome Bot commented Aug 20, 2026

Copy link
Copy Markdown

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e9c10cd-14f6-4984-8ca5-3f81765febcd

📥 Commits

Reviewing files that changed from the base of the PR and between a296708 and 8db03fc.

📒 Files selected for processing (1)
  • Makefile

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The check-deps message now states that Hugo is the npm-packaged binary. Dependency validation behavior is unchanged.

Changes

Dependency message

Layer / File(s) Summary
Update check-deps diagnostic
Makefile
The diagnostic message now refers to the npm-packaged Hugo binary instead of a local binary.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 8db03

This is a localized documentation-only wording change in the Makefile with no behavior impact; no actionable merge-blocking risk remains.

Suggested reviewers: banana-three-join, sbragul26

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the correction to the misleading Hugo dependency message.
Linked Issues check ✅ Passed The change updates the check-deps message to identify the npm-packaged Hugo binary, matching issue #1211.
Out of Scope Changes check ✅ Passed The pull request changes only the relevant Makefile message and introduces no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Makefile: Misleading message for check-deps

1 participant