Skip to content

Styling decoupling for Layout Resizers#1123

Closed
banana-three-join wants to merge 3 commits into
layer5io:masterfrom
banana-three-join:feature/banana-three-join/update-layout-resizers
Closed

Styling decoupling for Layout Resizers#1123
banana-three-join wants to merge 3 commits into
layer5io:masterfrom
banana-three-join:feature/banana-three-join/update-layout-resizers

Conversation

@banana-three-join

@banana-three-join banana-three-join commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

** Notes for reviewers **

  • Intended to provide reusability of the Layout Resizers both in Layer5 Docs and any module which utilizes Layer5 Docs as the parent module.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the layout resizer styles by moving them from assets/scss/_styles_project.scss into a new dedicated stylesheet assets/scss/_layout-resizers.scss, along with minor whitespace cleanups. Feedback on these changes highlights that the new stylesheet is not imported anywhere, which will prevent the styles from being compiled, and suggests using the $primary variable instead of a hardcoded color value to maintain theme consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@@ -0,0 +1,85 @@
// Left sidebar & Right sidebar Resize

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The newly created stylesheet _layout-resizers.scss is not imported in _styles_project.scss or any other main stylesheet. This will prevent these styles from being compiled and applied to the site. Please add @import "layout-resizers.scss"; to _styles_project.scss to ensure the styles are included.


.layout-resizer:hover,
.layout-resizer.is-dragging {
background-color: #00b39f;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid hardcoding the color value #00b39f here. Since this file will be imported into the main stylesheet where $primary is defined, you should continue using the $primary variable to maintain consistency and ensure that any future theme changes propagate automatically.

Suggested change
background-color: #00b39f;
background-color: $primary;

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-06-28 00:04 UTC

Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
@banana-three-join banana-three-join marked this pull request as ready for review June 26, 2026 19:40
@banana-three-join

Copy link
Copy Markdown
Contributor Author

Stale approach. Continued over: #1128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant