Styling decoupling for Layout Resizers#1123
Conversation
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request refactors the layout resizer styles by moving them from assets/scss/_styles_project.scss into a new dedicated stylesheet assets/scss/_layout-resizers.scss, along with minor whitespace cleanups. Feedback on these changes highlights that the new stylesheet is not imported anywhere, which will prevent the styles from being compiled, and suggests using the $primary variable instead of a hardcoded color value to maintain theme consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @@ -0,0 +1,85 @@ | |||
| // Left sidebar & Right sidebar Resize | |||
There was a problem hiding this comment.
|
|
||
| .layout-resizer:hover, | ||
| .layout-resizer.is-dragging { | ||
| background-color: #00b39f; |
There was a problem hiding this comment.
Avoid hardcoding the color value #00b39f here. Since this file will be imported into the main stylesheet where $primary is defined, you should continue using the $primary variable to maintain consistency and ensure that any future theme changes propagate automatically.
| background-color: #00b39f; | |
| background-color: $primary; |
|
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
|
Stale approach. Continued over: #1128 |
** Notes for reviewers **
Signed commits