YNU-864: API Reference rebuild from api.yaml#149
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fc67c5d to
7db6dd8
Compare
nksazonov
left a comment
There was a problem hiding this comment.
Good structural approach to the rebuild, but several fields are wrong or missing against api.yaml and need to be fixed before this lands.
nksazonov
left a comment
There was a problem hiding this comment.
Every comment addressed cleanly and completely. The field-name fix, missing pagination/metadata fields, optional-field notes, expanded examples, and the constraint documentation all landed exactly right. Great turnaround — ship it!
Summary
This PR replaces the old 0.5.x-style API Reference with a v1 RPC reference sourced from
docs/api.yamlin the Nitrolite repository.Intent
session_keys.v1page as a reserved stub because the group exists inapi.yamlbut has no methods yet.Files Touched
docs/nitrolite/api-reference/index.md: new v1 RPC landing page, Protocol-vs-API orientation, SDK-first guidance, wire-envelope note, group index, compat redirect, and MCP lookup hint.docs/nitrolite/api-reference/types.md: shared schema field tables fromdocs/api.yaml.docs/nitrolite/api-reference/channels-v1.md:channels.v1methods andhome_channel_createdevent note.docs/nitrolite/api-reference/app-sessions-v1.md:app_sessions.v1methods, including the app-registration prerequisite forcreate_app_session.docs/nitrolite/api-reference/apps-v1.md: app registry lookup andsubmit_app_versionregistration.docs/nitrolite/api-reference/user-v1.md: user balances, transactions, and allowances.docs/nitrolite/api-reference/node-v1.md: connectivity, config, and assets.docs/nitrolite/api-reference/errors.md: aggregated RPC errors and suggested user-facing handling.docs/nitrolite/api-reference/session-keys-v1.md: reserved stub for the emptysession_keys.v1group.docs/nitrolite/api-reference/app-sessions.md: removed old app-session helper reference, replaced byapp-sessions-v1.md.What Changed
docs/api.yaml.@yellow-org/sdk,@yellow-org/sdk-compat, andgithub.com/layer-3/nitrolite/sdk/go, including why they are safer than hand-rolled RPC for most apps.docs/api.yamlacrosschannels.v1,app_sessions.v1,apps.v1,user.v1, andnode.v1.application_not_registeredrecovery directly toapps.v1.submit_app_version.home_channel_createdevent while noting that async event notifications are reserved for a future protocol revision in the Interaction Model.Validation
git diff --checknpm run builddocs/api.yamlmethods have an H2 section indocs/nitrolite/api-reference/.session_keys.v1renders as a reserved stub.app_sessions.v1#create_app_session,channels.v1#submit_state, and the SDK-first landing-page orientation load correctly.The docs build still reports existing warnings from versioned 0.5.x and Clearnet contract docs. This PR does not add API Reference broken links or anchors.
Post-merge follow-up: add a CI drift check that fails if
docs/api.yamldiverges from the rendered API Reference pages.