feat(components): update DialogTrigger popover padding#1760
Closed
feat(components): update DialogTrigger popover padding#1760
Conversation
- Change from var(--lp-spacing-300) to var(--lp-spacing-400) var(--lp-spacing-600) - Vertical padding: 8px -> 12px - Horizontal padding: 8px -> 20px - Aligns with other popover implementations in the codebase Co-Authored-By: cpursley@launchdarkly.com <cpursley@launchdarkly.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: 6bed33a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
|
Size Change: +11 B (0%) Total Size: 533 kB
ℹ️ View Unchanged
|
- Update horizontal padding from var(--lp-spacing-600) to var(--lp-spacing-500) - Horizontal padding: 20px -> 16px - Vertical padding remains 12px (var(--lp-spacing-400)) Co-Authored-By: cpursley@launchdarkly.com <cpursley@launchdarkly.com>
nhironaka
approved these changes
Aug 28, 2025
Co-Authored-By: cpursley@launchdarkly.com <cpursley@launchdarkly.com>
matthewferry
suggested changes
Sep 9, 2025
Contributor
matthewferry
left a comment
matthewferry
left a comment
There was a problem hiding this comment.
One small nit to use size tokens instead so it's clearer.
|
|
||
| &[data-trigger='DialogTrigger'] { | ||
| padding: var(--lp-spacing-300); | ||
| padding: var(--lp-spacing-400) var(--lp-spacing-500); |
Contributor
There was a problem hiding this comment.
Nit: replace spacing tokens with explicit sizes
Suggested change
| padding: var(--lp-spacing-400) var(--lp-spacing-500); | |
| padding: var(--lp-size-12) var(--lp-size-16); |
matthewferry
reviewed
Sep 9, 2025
Comment on lines
+8
to
+9
| - Vertical padding: 8px → 12px (var(--lp-spacing-400)) | ||
| - Horizontal padding: 8px → 16px (var(--lp-spacing-500)) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Vertical padding: 8px → 12px (var(--lp-spacing-400)) | |
| - Horizontal padding: 8px → 16px (var(--lp-spacing-500)) | |
| - Vertical padding: 8px → 12px (var(--lp-size-12)) | |
| - Horizontal padding: 8px → 16px (var(--lp-size-16)) |
- Replace var(--lp-spacing-400) var(--lp-spacing-500) with var(--lp-size-12) var(--lp-size-16) - Update changeset description to reference size tokens for clarity - Addresses PR feedback from matthewferry Co-Authored-By: cpursley@launchdarkly.com <cpursley@launchdarkly.com>
matthewferry
approved these changes
Oct 23, 2025
…nputs" This reverts commit 1ff346a.
Contributor
Author
|
not fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the default padding for DialogTrigger popovers from uniform 8px padding to differentiated vertical/horizontal padding:
var(--lp-spacing-300)→var(--lp-spacing-400))var(--lp-spacing-300)→var(--lp-spacing-500))This change aligns DialogTrigger popover padding with other popover implementations found throughout the codebase that use
var(--lp-spacing-400) var(--lp-spacing-500)patterns.Screenshots
Visual change tested in Storybook showing updated popover padding:
Testing approaches
Human Review Checklist
padding: var(--lp-spacing-400) var(--lp-spacing-600)correctly maps to 12px vertical, 20px horizontalLink to Devin run: https://app.devin.ai/sessions/368850b37e0e415da75e94ccc77d75ba
Requested by: @cpurps22