fix: Report data source state as valid after bootstrap#1203
Open
kinyoklion wants to merge 1 commit intomainfrom
Open
fix: Report data source state as valid after bootstrap#1203kinyoklion wants to merge 1 commit intomainfrom
kinyoklion wants to merge 1 commit intomainfrom
Conversation
When loading bootstrap data, the data source status was never updated to VALID, leaving it in the default CLOSED state. This adds the missing requestStateUpdate call so consumers can rely on dataSourceStatus events for bootstrap-initialized clients.
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
joker23
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: a small state-reporting change limited to the bootstrap identify path, covered by an updated unit test asserting the
dataSourceStatusevent.Overview
When
identifycompletes usingbootstrapdata,BrowserDataManagernow explicitly reports the data source status as valid by callingdataSourceStatusManager.requestStateUpdate(DataSourceState.Valid).The bootstrap identify unit test is updated to assert that a
dataSourceStatusevent is emitted withstate: 'VALID'after bootstrap initialization.Written by Cursor Bugbot for commit 6d3276f. This will update automatically on new commits. Configure here.