-
Notifications
You must be signed in to change notification settings - Fork 11
chore: adds transactional memory store #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tanderson-ld
merged 3 commits into
main
from
ta/SDK-1619/adding-transactional-memory-store
Jan 14, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/CacheExporter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package com.launchdarkly.sdk.server; | ||
|
|
||
| import com.launchdarkly.sdk.server.subsystems.DataStoreTypes.FullDataSet; | ||
| import com.launchdarkly.sdk.server.subsystems.DataStoreTypes.ItemDescriptor; | ||
|
|
||
| /** | ||
| * Optional interface for data stores that can export their entire contents. | ||
| * <p> | ||
| * This interface is used to enable recovery scenarios where a persistent store | ||
| * needs to be re-synchronized from an in-memory cache. Not all data stores need | ||
| * to implement this interface. | ||
| * <p> | ||
| * This is currently only for internal implementations. | ||
| */ | ||
| interface CacheExporter { | ||
| /** | ||
| * Exports all data from the cache across all known DataKinds. | ||
| * | ||
| * @return A FullDataSet containing all items in the cache. The data is a snapshot | ||
| * taken at the time of the call and may be stale immediately after return. | ||
| */ | ||
| FullDataSet<ItemDescriptor> exportAll(); | ||
|
|
||
| /** | ||
| * Indicates if the cache has been populated with a full data set. | ||
| * | ||
| * @return true when the cache has been populated | ||
| */ | ||
| boolean isInitialized(); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...k/server/src/main/java/com/launchdarkly/sdk/server/subsystems/TransactionalDataStore.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package com.launchdarkly.sdk.server.subsystems; | ||
|
|
||
| import com.launchdarkly.sdk.internal.fdv2.sources.Selector; | ||
| import com.launchdarkly.sdk.server.subsystems.DataStoreTypes.ChangeSet; | ||
| import com.launchdarkly.sdk.server.subsystems.DataStoreTypes.ItemDescriptor; | ||
|
|
||
| /** | ||
| * Interface for a data store that holds feature flags and related data received by the SDK. | ||
| * This interface supports updating the store transactionally using ChangeSets. | ||
| * <p> | ||
| * Ordinarily, the only implementation of this interface is the default in-memory | ||
| * implementation, which holds references to actual SDK data model objects. Any data store | ||
| * implementation that uses an external store, such as a database, should instead use | ||
| * {@link PersistentDataStore}. | ||
| * <p> | ||
| * Implementations must be thread-safe. | ||
| * <p> | ||
| * This interface is not stable, and not subject to any backwards compatibility guarantees or semantic versioning. | ||
| * It is in early access. If you want access to this feature please join the EAP. https://launchdarkly.com/docs/sdk/features/data-saving-mode | ||
| * | ||
| * @see PersistentDataStore | ||
| */ | ||
| public interface TransactionalDataStore { | ||
| /** | ||
| * Apply the given change set to the store. This should be done atomically if possible. | ||
| * | ||
| * @param changeSet the changeset to apply | ||
| */ | ||
| void apply(ChangeSet<ItemDescriptor> changeSet); | ||
|
|
||
| /** | ||
| * Returns the selector for the currently stored data. The selector will be non-null but may be empty. | ||
| * | ||
| * @return the selector for the currently stored data | ||
| */ | ||
| Selector getSelector(); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: I come from the future, and 1.6.1 solves all of humanities problems.