Conversation
kinyoklion
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty straightforward port of
FDv2ChangeSetand related classes from Java, as well as the protocol objects, such asPutObject,DeleteObject, etc.FDv2Change,FDv2ChangeSetobjects for use in data system.ServerIntent,PutObject, etc methods for parsing messages from backend.tag_invokemethods based on the existing json deserialization code.Note
Medium Risk
Introduces new protocol-level JSON deserialization and data model types that will be used for streaming/data-sync, so schema/compatibility mistakes could affect data updates despite being mostly additive and covered by unit tests.
Overview
Adds initial FDv2 wire-format support by introducing
Selector,FDv2Change, andFDv2ChangeSettypes for representing full/partial/no-op data updates.Implements JSON deserialization (Boost.JSON
tag_invoke) for FDv2 protocol messages—IntentCode,ServerIntent,PutObject,DeleteObject,PayloadTransferred,Goodbye, andFDv2Error—and wires the new parser into the internal build (serialization/json_fdv2_events.cpp).Adds comprehensive unit tests (
fdv2_serialization_test.cpp) validating successful parsing, null handling, and schema-failure behavior for missing/invalid fields.Written by Cursor Bugbot for commit 11be538. This will update automatically on new commits. Configure here.