Skip to content

chore: add explicit permissions to release-please workflow#513

Merged
kinyoklion merged 2 commits intomainfrom
devin/1774469061-add-release-please-permissions
Mar 25, 2026
Merged

chore: add explicit permissions to release-please workflow#513
kinyoklion merged 2 commits intomainfrom
devin/1774469061-add-release-please-permissions

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Mar 25, 2026

Summary

Adds explicit contents: write and pull-requests: write permissions to the release-please job. These are required for the release-please action to create release PRs and GitHub releases. Without explicit permissions, the job relies on the repository/org default GITHUB_TOKEN permissions, which may be insufficient if defaults are tightened to read-only.

Downstream jobs (release-client, release-server, provenance, etc.) already have their own explicit permissions blocks and are unaffected by this change.

Review & Testing Checklist for Human

  • Verify no other implicit permissions are needed by the release-please job. Adding an explicit job-level permissions block restricts the token to only the listed permissions, revoking any previously inherited defaults. If the release-please action in this repo needs anything beyond contents and pull-requests (e.g., id-token: write), it will break.
  • After merging, monitor the next release-please workflow run (triggered by a push to main) to confirm it still creates/updates release PRs successfully.

Notes

This is part of a batch update across all launchdarkly-sdk-tagged repositories whose release-please workflows were missing explicit permissions on their default branch.

Link to Devin session: https://app.devin.ai/sessions/a83b6e4f4fa14b96b859cfb50755a2c1
Requested by: @kinyoklion


Note

Low Risk
Low risk configuration change, but it can break releases if release-please requires additional permissions beyond contents and pull-requests under restricted tokens.

Overview
Hardens the release-please GitHub Actions workflow by adding an explicit job-level permissions block for release-please (contents: write and pull-requests: write).

This removes reliance on repository/org default GITHUB_TOKEN permissions and ensures the job can create/update release PRs and GitHub releases when defaults are tightened.

Written by Cursor Bugbot for commit 16f70bb. This will update automatically on new commits. Configure here.

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@kinyoklion kinyoklion marked this pull request as ready for review March 25, 2026 20:17
@kinyoklion kinyoklion requested a review from a team as a code owner March 25, 2026 20:17
@kinyoklion kinyoklion merged commit 0edb808 into main Mar 25, 2026
46 checks passed
@kinyoklion kinyoklion deleted the devin/1774469061-add-release-please-permissions branch March 25, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants