ci: replace thedoctor0/zip-release with in-repo composite action#512
Open
kinyoklion wants to merge 4 commits intomainfrom
Open
ci: replace thedoctor0/zip-release with in-repo composite action#512kinyoklion wants to merge 4 commits intomainfrom
kinyoklion wants to merge 4 commits intomainfrom
Conversation
Replace the external thedoctor0/zip-release GitHub Action with a local composite action at .github/actions/zip-release that uses built-in runner tools (zip on Linux/macOS, 7z on Windows). Includes a temporary test workflow to verify the zip action produces correct output on all three platforms. Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the external
thedoctor0/zip-release@0.7.1GitHub Action with a local composite action at.github/actions/zip-release/. The new action uses tools built into the GitHub runner images:zip -r7z a -tzipThis matches the exact commands the old action ran internally. All 16 call sites in
sdk-release/action.ymlare updated, and the now-unnecessarytype: 'zip'parameter is removed.Verification
A temporary test workflow (
test-zip-release.yml) was used during development to validate the action on all 3 platforms (Ubuntu 22.04, Windows 2022, macOS 15). It confirmed:build-static/release/...(no extra root folder introduced)The test workflow passed on all platforms and has been removed from the final PR.
Review & Testing Checklist for Human
pathdirectly tozip/7zwithoutcd-ing into the directory first, so archives contain thebuild-*/release/prefix (e.g.,build-static/release/include/...). This matches the oldthedoctor0/zip-releasebehavior. Consider downloading a zip from a past release and comparing the structure.ubuntu-22.04,windows-2022,macos-15-large,macos-15). The CI tests used dummy files, not actual build output.pathinput is unquoted inzip-release/action.yml— this matches the old action's behavior but means paths with spaces would break. All current call sites use simple paths so this is fine, but worth being aware of.Notes
build-*/releasepath prefix (e.g.,build-static/release/include/...), which is the same behavior as the oldthedoctor0/zip-releaseaction when givenpath: 'build-static/release'without changing the working directory.Link to Devin session: https://app.devin.ai/sessions/029a65c529684166adf9a71e21d32778
Requested by: @kinyoklion
Note
Medium Risk
Touches the release artifact packaging path across Linux/Windows/macOS; a small command/quoting difference could change zip contents or fail builds, impacting published releases.
Overview
Replaces all uses of the external
thedoctor0/zip-releaseaction in thesdk-releasecomposite workflow with a new in-repo composite action, and removes the now-unusedtype: 'zip'input.Adds
.github/actions/zip-releaseto create archives using runner-native tooling (zip -ron Linux/macOS,7z a -tzipon Windows), keeping artifact filenames and call sites otherwise the same.Written by Cursor Bugbot for commit 069781c. This will update automatically on new commits. Configure here.