Skip to content

ci: replace thedoctor0/zip-release with in-repo composite action#512

Open
kinyoklion wants to merge 4 commits intomainfrom
devin/1774369396-replace-zip-release
Open

ci: replace thedoctor0/zip-release with in-repo composite action#512
kinyoklion wants to merge 4 commits intomainfrom
devin/1774369396-replace-zip-release

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Mar 24, 2026

Summary

Replaces the external thedoctor0/zip-release@0.7.1 GitHub Action with a local composite action at .github/actions/zip-release/. The new action uses tools built into the GitHub runner images:

  • Linux/macOS: zip -r
  • Windows: 7z a -tzip

This matches the exact commands the old action ran internally. All 16 call sites in sdk-release/action.yml are updated, and the now-unnecessary type: 'zip' parameter is removed.

Verification

A temporary test workflow (test-zip-release.yml) was used during development to validate the action on all 3 platforms (Ubuntu 22.04, Windows 2022, macOS 15). It confirmed:

  • Zip files are created with the correct filenames matching sdk-release expectations
  • Internal path structure is build-static/release/... (no extra root folder introduced)
  • The action works identically on Linux, macOS, and Windows

The test workflow passed on all platforms and has been removed from the final PR.

Review & Testing Checklist for Human

  • Verify the zip archive internal structure — the action passes path directly to zip/7z without cd-ing into the directory first, so archives contain the build-*/release/ prefix (e.g., build-static/release/include/...). This matches the old thedoctor0/zip-release behavior. Consider downloading a zip from a past release and comparing the structure.
  • Run the manual release workflow against a test tag to confirm end-to-end correctness with real build artifacts on all platforms (ubuntu-22.04, windows-2022, macos-15-large, macos-15). The CI tests used dummy files, not actual build output.
  • Note the path input is unquoted in zip-release/action.yml — this matches the old action's behavior but means paths with spaces would break. All current call sites use simple paths so this is fine, but worth being aware of.

Notes

  • The zip archive internal structure preserves the build-*/release path prefix (e.g., build-static/release/include/...), which is the same behavior as the old thedoctor0/zip-release action when given path: 'build-static/release' without changing the working directory.
  • No changes to the actual build scripts, hash computation, or upload steps — only the zip creation step is swapped.

Link to Devin session: https://app.devin.ai/sessions/029a65c529684166adf9a71e21d32778
Requested by: @kinyoklion


Note

Medium Risk
Touches the release artifact packaging path across Linux/Windows/macOS; a small command/quoting difference could change zip contents or fail builds, impacting published releases.

Overview
Replaces all uses of the external thedoctor0/zip-release action in the sdk-release composite workflow with a new in-repo composite action, and removes the now-unused type: 'zip' input.

Adds .github/actions/zip-release to create archives using runner-native tooling (zip -r on Linux/macOS, 7z a -tzip on Windows), keeping artifact filenames and call sites otherwise the same.

Written by Cursor Bugbot for commit 069781c. This will update automatically on new commits. Configure here.

Replace the external thedoctor0/zip-release GitHub Action with a local
composite action at .github/actions/zip-release that uses built-in
runner tools (zip on Linux/macOS, 7z on Windows).

Includes a temporary test workflow to verify the zip action produces
correct output on all three platforms.

Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 3 commits March 24, 2026 16:32
Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
@kinyoklion kinyoklion marked this pull request as ready for review March 24, 2026 22:17
@kinyoklion kinyoklion requested a review from a team as a code owner March 24, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant