fix(postgres): make advisory lock cancel safe#4199
Merged
abonander merged 3 commits intolaunchbadge:mainfrom Mar 26, 2026
Merged
fix(postgres): make advisory lock cancel safe#4199abonander merged 3 commits intolaunchbadge:mainfrom
abonander merged 3 commits intolaunchbadge:mainfrom
Conversation
bonsairobo
reviewed
Mar 24, 2026
Contributor
Author
|
Note: I've decided to not update the |
abonander
requested changes
Mar 25, 2026
Collaborator
abonander
left a comment
There was a problem hiding this comment.
Note: I've decided to not update the
try_acquireimplementation because releasing the lock depends on the result of the query. So that method is still not cancel safe unfortunately.
Can you just update the documentation to explain that? And add a Cancel Safety clause to the regular lock method that explains what it'll do on cancel?
abonander
approved these changes
Mar 26, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr makes the
PgAdvisoryLock::acquirecancel safe by wrapping the connection in aPgAdvisoryLockbefore actually acquiring the lock. If theacquirefuture is dropped the drop impl will release the lock.Does your PR solve an issue?
fixes #4198
Is this a breaking change?
Nope