build: Non-automagic pkcs11 pin support#569
Open
salahcoronya wants to merge 1 commit into
Open
Conversation
Signed-off-by: Christopher Byrne <salah.coronya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the pins (except tpm1) use automagic detection. Most of the other pins this isn't really a problem, as their dependencies are small and/or already likely to be installed. However, the pkcs11 pin pulls in pcsc-lite (which isn't a very common package), which is turns pulls in polkit (which some people consider bloat) and all its dependencies.
The others are either have low dependency requirements, or are highly desirable (tpm2), and can simply be made outright requirements by the packager.