fix(codex): keep finished subagents from pinning Working - #48
Merged
lastobelus merged 3 commits intoAug 21, 2026
Merged
Conversation
The revival guard only covered `progress`, so a status-free `updated` sailed past it and put an already-dropped task back in the live set. Claude's adapter emits exactly that whenever a task patch carries only a description, error, end_time or is_backgrounded, which left the sidebar pill pinned on "working" until session exit. Same bug class as pingdotgg#7128/pingdotgg#7172, which fixed it for `progress` only. `started` stays excluded on purpose so a genuine restart still revives; a second test pins that so the guard can't over-correct.
lastobelus
force-pushed
the
port/upstream/codex-subagent-working-state
branch
from
August 21, 2026 21:56
681de6f to
05bbb5d
Compare
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
lastobelus
marked this pull request as ready for review
August 21, 2026 22:37
lastobelus
added a commit
that referenced
this pull request
Aug 22, 2026
Codex can emit a trailing interacted notification after a child turn completes, and can emit a real child turn start before the activity that registers that child. Treating every interaction as running revives idle children, while treating every interaction as metadata can miss a genuinely live pre-registration turn. This port retains the complete upstream candidate: - pingdotgg#7848 maps interacted to a status-free identity update and replays an explicit start only when registration finds a recorded live turn. - pingdotgg#7468 hardens generic task liveness so status-free task.updated events cannot revive an idle task; its original authored commit is preserved. Upstream PR: pingdotgg#7848 Generic hardening PR: pingdotgg#7468 Issue: pingdotgg#7726 Validation: - 87 focused adapter, runtime, liveness, and client-fold tests passed - focused lint and formatting passed - quick local CI passed before the review fix; final exact-head full CI will run before merge Prepared by gpt-5.6-sol through the Codex harness. --------- Co-authored-by: Jeremy Schoemaker <jeremy@shoemoney.com>
lastobelus
added a commit
that referenced
this pull request
Aug 22, 2026
Codex can emit a trailing interacted notification after a child turn completes, and can emit a real child turn start before the activity that registers that child. Treating every interaction as running revives idle children, while treating every interaction as metadata can miss a genuinely live pre-registration turn. This port retains the complete upstream candidate: - pingdotgg#7848 maps interacted to a status-free identity update and replays an explicit start only when registration finds a recorded live turn. - pingdotgg#7468 hardens generic task liveness so status-free task.updated events cannot revive an idle task; its original authored commit is preserved. Upstream PR: pingdotgg#7848 Generic hardening PR: pingdotgg#7468 Issue: pingdotgg#7726 Validation: - 87 focused adapter, runtime, liveness, and client-fold tests passed - focused lint and formatting passed - quick local CI passed before the review fix; final exact-head full CI will run before merge Prepared by gpt-5.6-sol through the Codex harness. --------- Co-authored-by: Jeremy Schoemaker <jeremy@shoemoney.com>
lastobelus
added a commit
that referenced
this pull request
Aug 22, 2026
Codex can emit a trailing interacted notification after a child turn completes, and can emit a real child turn start before the activity that registers that child. Treating every interaction as running revives idle children, while treating every interaction as metadata can miss a genuinely live pre-registration turn. This port retains the complete upstream candidate: - pingdotgg#7848 maps interacted to a status-free identity update and replays an explicit start only when registration finds a recorded live turn. - pingdotgg#7468 hardens generic task liveness so status-free task.updated events cannot revive an idle task; its original authored commit is preserved. Upstream PR: pingdotgg#7848 Generic hardening PR: pingdotgg#7468 Issue: pingdotgg#7726 Validation: - 87 focused adapter, runtime, liveness, and client-fold tests passed - focused lint and formatting passed - quick local CI passed before the review fix; final exact-head full CI will run before merge Prepared by gpt-5.6-sol through the Codex harness. --------- Co-authored-by: Jeremy Schoemaker <jeremy@shoemoney.com>
lastobelus
added a commit
that referenced
this pull request
Aug 22, 2026
Codex can emit a trailing interacted notification after a child turn completes, and can emit a real child turn start before the activity that registers that child. Treating every interaction as running revives idle children, while treating every interaction as metadata can miss a genuinely live pre-registration turn. This port retains the complete upstream candidate: - pingdotgg#7848 maps interacted to a status-free identity update and replays an explicit start only when registration finds a recorded live turn. - pingdotgg#7468 hardens generic task liveness so status-free task.updated events cannot revive an idle task; its original authored commit is preserved. Upstream PR: pingdotgg#7848 Generic hardening PR: pingdotgg#7468 Issue: pingdotgg#7726 Validation: - 87 focused adapter, runtime, liveness, and client-fold tests passed - focused lint and formatting passed - quick local CI passed before the review fix; final exact-head full CI will run before merge Prepared by gpt-5.6-sol through the Codex harness. --------- Co-authored-by: Jeremy Schoemaker <jeremy@shoemoney.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex can emit a trailing interacted notification after a child turn completes, and can emit a real child turn start before the activity that registers that child. Treating every interaction as running revives idle children, while treating every interaction as metadata can miss a genuinely live pre-registration turn.
This port retains the complete upstream candidate:
Upstream PR: pingdotgg#7848
Generic hardening PR: pingdotgg#7468
Issue: pingdotgg#7726
Validation:
Prepared by gpt-5.6-sol through the Codex harness.