Fix latin1 encoding for German umlauts in bank statements#20
Merged
larsdecker merged 2 commits intomasterfrom Dec 22, 2025
Merged
Fix latin1 encoding for German umlauts in bank statements#20larsdecker merged 2 commits intomasterfrom
larsdecker merged 2 commits intomasterfrom
Conversation
Co-authored-by: larsdecker <1968186+larsdecker@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues from pull request #34
Fix latin1 encoding for German umlauts in bank statements
Dec 22, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes an encoding issue in the FinTS client where German umlauts (ä, ö, ü, ß) were displaying incorrectly in bank statement data. The fix changes the character encoding from UTF-8 to latin1 (ISO-8859-1) when parsing MT940-formatted bank statements, which is the correct encoding used by the FinTS protocol.
- Changed
Buffer.from(bookedString, "utf-8")toBuffer.from(bookedString, "latin1")in the statement parsing logic - Ports an upstream fix from Prior99#34
- Aligns with existing encoding usage in the codebase (ISO-8859-1 is already used in
utils.tsandparse.ts)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FinTS protocol returns bank statement data in latin1 encoding, but the client was decoding as utf-8, causing German umlauts (ä, ö, ü, ß) to display incorrectly.
Changes
utf-8tolatin1inClient.statements()method when parsing booked transactionsPorts the fix from upstream Prior99#34.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.