Skip to content

[trivial] sgn for unsigned#633

Merged
Yurlungur merged 4 commits intomainfrom
jmm/sgn-for-unsigned
Apr 10, 2026
Merged

[trivial] sgn for unsigned#633
Yurlungur merged 4 commits intomainfrom
jmm/sgn-for-unsigned

Conversation

@Yurlungur
Copy link
Copy Markdown
Collaborator

@Yurlungur Yurlungur commented Apr 10, 2026

PR Summary

This MR just eliminates a warning for comparison against zero for unsigned integral types when calling robust::sgn.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@Yurlungur Yurlungur self-assigned this Apr 10, 2026
@Yurlungur Yurlungur added the clean-up Changes that don't affect code execution but make the code cleaner label Apr 10, 2026
@Yurlungur Yurlungur merged commit a137bd7 into main Apr 10, 2026
9 checks passed
@Yurlungur Yurlungur deleted the jmm/sgn-for-unsigned branch April 10, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-up Changes that don't affect code execution but make the code cleaner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants