Langfuse ddtrace opentelemetry #1505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ddtrace (v4.x) or similar OpenTelemetry integrations set up an API-only TracerProvider before Langfuse initializes, Langfuse would fail with: AttributeError: 'TracerProvider' object has no attribute 'add_span_processor' This occurred because Langfuse assumed that any non-ProxyTracerProvider would be an SDK TracerProvider with the add_span_processor method. The fix updates _init_tracer_provider() to handle three scenarios: 1. No provider set (ProxyTracerProvider): Creates SDK provider and sets as global 2. SDK TracerProvider already set: Reuses the existing provider 3. Non-SDK TracerProvider (e.g., ddtrace): Creates a new SDK provider for Langfuse without overriding the global provider This allows Langfuse to work alongside ddtrace and other OpenTelemetry integrations that don't use the SDK TracerProvider. Addresses issue reported in GitHub discussions about ddtrace v4.x compatibility. Co-authored-by: jannik <jannik@langfuse.com>
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve OpenTelemetry TracerProvider initialization to be compatible with non-SDK providers like ddtrace v4.x.
Previously, if a non-SDK
TracerProvider(e.g., fromddtracev4.x) was globally set, Langfuse would fail due to the absence of theadd_span_processormethod. This change allows Langfuse to create and use its own SDKTracerProviderinternally without attempting to override the existing global provider, preventingAttributeErrorand "Overriding of current TracerProvider is not allowed" errors.