ci: add lfx paths to CI path filters#11212
Conversation
Changes to src/lfx were not triggering CI tests because the path filters did not include lfx directories. This adds lfx paths to: - python: triggers backend tests for any lfx changes - docker: triggers docker tests when lfx changes - components-changes: lfx components - components: lfx components, custom, schema, graph - workspace: lfx inputs
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ogabrielluiz
requested review from
Cristhianzl,
edwinjosechittilappilly and
jordanrfrazier
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @.github/changes-filter.yaml:
- Around line 76-79: The components filter for the lfx package is missing
patterns for the utils and serialization directories; update the
.github/changes-filter.yaml lfx filter group (the block containing
"src/lfx/src/lfx/components/**", "src/lfx/src/lfx/custom/**",
"src/lfx/src/lfx/schema/**", "src/lfx/src/lfx/graph/**") by adding entries for
"src/lfx/src/lfx/utils/**" and "src/lfx/src/lfx/serialization/**" immediately
after that block, and ensure you do not add an entry for a non-existent
"initial_setup" directory.
🧹 Nitpick comments (1)
.github/changes-filter.yaml (1)
10-10: Consider removing redundant path.The path
src/lfx/pyproject.tomlon line 10 is already covered by the broadersrc/lfx/**pattern on line 5.🔎 Proposed fix
- "src/lfx/**" - "pyproject.toml" - "uv.lock" - "src/backend/base/pyproject.toml" - "src/backend/base/uv.lock" - - "src/lfx/pyproject.toml" - "**/python_test.yml"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/changes-filter.yaml
🧰 Additional context used
🧠 Learnings (6)
📚 Learning: 2025-11-24T19:46:09.104Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-11-24T19:46:09.104Z
Learning: Applies to src/backend/base/langflow/components/**/*.py : Add new components to the appropriate subdirectory under `src/backend/base/langflow/components/` (agents/, data/, embeddings/, input_output/, models/, processing/, prompts/, tools/, or vectorstores/)
Applied to files:
.github/changes-filter.yaml
📚 Learning: 2025-11-24T19:46:09.104Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/backend_development.mdc:0-0
Timestamp: 2025-11-24T19:46:09.104Z
Learning: Applies to src/backend/base/langflow/components/**/__init__.py : Update `__init__.py` with alphabetically sorted imports when adding new components
Applied to files:
.github/changes-filter.yaml
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/backend/tests/**/*.py : Use same filename as component with appropriate test prefix/suffix (e.g., `my_component.py` → `test_my_component.py`)
Applied to files:
.github/changes-filter.yaml
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/backend/tests/**/*.py : Test component versioning and backward compatibility using `file_names_mapping` fixture with `VersionComponentMapping` objects mapping component files across Langflow versions
Applied to files:
.github/changes-filter.yaml
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/backend/tests/**/*.py : Place backend unit tests in `src/backend/tests/` directory, component tests in `src/backend/tests/unit/components/` organized by component subdirectory, and integration tests accessible via `make integration_tests`
Applied to files:
.github/changes-filter.yaml
📚 Learning: 2025-11-24T19:46:45.790Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-11-24T19:46:45.790Z
Learning: Applies to src/frontend/src/components/**/*.{tsx,jsx} : Use React Flow for flow graph visualization with Node, Edge, Controls, and Background components
Applied to files:
.github/changes-filter.yaml
🔇 Additional comments (3)
.github/changes-filter.yaml (3)
36-36: LGTM!The addition of
src/lfx/**to the docker filter group is consistent with the backend pattern and correctly ensures that lfx changes trigger docker tests.
16-16: LGTM!The addition correctly mirrors the backend components pattern and ensures lfx component changes are properly detected.
5-5: Overall structure and approach look good.The additions successfully achieve the PR objective of ensuring lfx changes trigger appropriate CI workflows. The path patterns are consistent with the existing backend structure, making the configuration maintainable and predictable.
Also applies to: 16-16, 36-36, 76-79, 84-84
| - "src/lfx/src/lfx/components/**" | ||
| - "src/lfx/src/lfx/custom/**" | ||
| - "src/lfx/src/lfx/schema/**" | ||
| - "src/lfx/src/lfx/graph/**" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if utils, initial_setup, and serialization directories exist in lfx
echo "Checking for lfx directories that might need to be added to filters:"
echo ""
echo "=== Checking for utils directory ==="
fd -t d "^utils$" src/lfx/src/lfx/ 2>/dev/null || echo "Not found"
echo ""
echo "=== Checking for initial_setup directory ==="
fd -t d "^initial_setup$" src/lfx/src/lfx/ 2>/dev/null || echo "Not found"
echo ""
echo "=== Checking for serialization directory ==="
fd -t d "^serialization$" src/lfx/src/lfx/ 2>/dev/null || echo "Not found"
echo ""
echo "=== Current lfx directory structure (top level) ==="
fd -t d . src/lfx/src/lfx/ --max-depth 1 2>/dev/null || echo "src/lfx/src/lfx/ not found"Repository: langflow-ai/langflow
Length of output: 994
Add missing lfx directories to the components filter group.
The lfx package contains utils and serialization directories that exist in the backend components filter but are missing from the lfx filter. Add these lines after line 79:
- "src/lfx/src/lfx/utils/**"
- "src/lfx/src/lfx/serialization/**"
The initial_setup directory does not exist in lfx, so it should not be included.
🤖 Prompt for AI Agents
In @.github/changes-filter.yaml around lines 76 - 79, The components filter for
the lfx package is missing patterns for the utils and serialization directories;
update the .github/changes-filter.yaml lfx filter group (the block containing
"src/lfx/src/lfx/components/**", "src/lfx/src/lfx/custom/**",
"src/lfx/src/lfx/schema/**", "src/lfx/src/lfx/graph/**") by adding entries for
"src/lfx/src/lfx/utils/**" and "src/lfx/src/lfx/serialization/**" immediately
after that block, and ensure you do not add an entry for a non-existent
"initial_setup" directory.
Frontend Unit Test Coverage ReportCoverage Summary
Unit Test Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (42.29%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11212 +/- ##
==========================================
- Coverage 37.33% 37.32% -0.01%
==========================================
Files 1592 1592
Lines 78279 78279
Branches 11824 11824
==========================================
- Hits 29226 29219 -7
- Misses 47432 47440 +8
+ Partials 1621 1620 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Changes to src/lfx were not triggering CI tests because the path filters did not include lfx directories. This adds lfx paths to: - python: triggers backend tests for any lfx changes - docker: triggers docker tests when lfx changes - components-changes: lfx components - components: lfx components, custom, schema, graph - workspace: lfx inputs
2 participants
Summary
Changes to
src/lfxwere not triggering CI tests because the path filters did not include lfx directories.This adds lfx paths to the following filters:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.