refactor: make index file versions exact - #8028
Draft
Xuanwo wants to merge 2 commits into
Draft
Conversation
…xuanwo/exact-version-stack-11-index-consumers
github-actions
Bot
added
A-python
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 11/12 of #7877. Depends on #8027.
This is an independently reviewable step toward the final layout demonstrated in #7979.
This PR converts scalar and vector index readers, writers, shufflers, and distributed mergers to exact
ConcreteFileVersionidentities. Dataset-backed indexes inherit the dataset format explicitly; legacy dataset physical indexes map explicitly to V2.0.With the last transitional consumers migrated, this PR removes file-version ordering and implicit conversions between selectors and exact formats. Remaining version decisions are exhaustive matches at declared boundaries rather than
>=,max, or selector round-trips.Validation:
cargo clippy --all --tests --benches -- -D warnings