refactor: move file-version selectors to lance-file - #8026
Draft
Xuanwo wants to merge 2 commits into
Draft
Conversation
…o xuanwo/exact-version-stack-09-selector-ownership
github-actions
Bot
added
A-index
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 9/12 of #7877. Depends on #8025.
This is an independently reviewable step toward the final layout demonstrated in #7979.
StableandNextare file-writing selectors, not encoding mechanisms. This PR movesLanceFileVersionand selector resolution fromlance-encodingtolance-file, leavingConcreteFileVersionas the exact identity consumed below that boundary.This step deliberately preserves the existing selector API and transitional conversions so the ownership move compiles independently. Dataset operation policy is migrated in part 10, and part 11 removes the remaining index-boundary conversions, ordering, and implicit exact/selector conversions.
Validation: