feat(index): add zone map support for FixedSizeList of primitive types - #8017
Draft
westonpace wants to merge 1 commit into
Draft
feat(index): add zone map support for FixedSizeList of primitive types#8017westonpace wants to merge 1 commit into
westonpace wants to merge 1 commit into
Conversation
Adds per-position min/max statistics for FixedSizeList columns so the zone map can prune zones during equality queries on fixed-size list (e.g. embedding vector) columns. Key changes: - New `FixedSizeListZoneAccumulator` tracks per-position min/max as `Vec<Option<ScalarValue>>` across all non-null list entries in a zone. - `ZoneMapProcessor` dispatches through a new `ZoneMapAccumulator` enum that selects between scalar and FSL accumulators based on the column type. - `evaluate_fsl_equals` performs per-position range checks: a zone is pruned when any element of the query list falls outside `[min[j], max[j]]`. - `Equals` and `IsIn` queries delegate to `evaluate_fsl_equals` for FSL targets; `Range` and `LikePrefix` conservatively return true. - `value_range` / `value_range_over` return `None` for FSL zones. - The `is_nested()` guard in `new_training_request` and `create_seed_writer` is lifted for `FixedSizeList<non-nested>` types. - `default_use_seeds` returns true for all `FixedSizeList` columns. - Six new tests cover pruning, null lists, IsIn, NaN elements, all-null zones, and value_range behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
A-index
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My original plan was to add zone map for ALL arrow types. However, after review, I think probably don't need to rush for zone maps on list or struct types. So this is a more targeted fix to just address FSL (and even then, only FSL of a non-nested type)