feat: shard directory namespace manifest#7240
Open
jackye1995 wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
57195ae to
075e403
Compare
Contributor
Author
|
Update: the branch now also rebuilds the inline scalar index section for sharded manifest rewrites. The detailed S3 benchmark above was collected before this follow-up, when sharded rewrites skipped inline index rebuilds, so those numbers should be treated as pre-index-build results. We should rerun the same S3 panel before using the benchmark as final merge evidence. |
075e403 to
7fe19fe
Compare
Contributor
Author
S3 benchmark: sharded manifest with shard-local inline index segmentsThis reruns the S3 manifest commit benchmark after the sharded manifest index fix:
Setup:
Run IDs:
Continuous, 100 commits
Concurrent, c=10 for 30s
Concurrent, c=100 for 30s
Takeaways
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest_shard_countsupport for directory namespace manifests__manifestinto routed physical fragments while keeping the manifest schema unchangedBenchmark
jack-devland-build,write-create-namespace