fix: scan all-null columns after dropping physical columns#7238
Open
skyshineb wants to merge 1 commit into
Open
fix: scan all-null columns after dropping physical columns#7238skyshineb wants to merge 1 commit into
skyshineb wants to merge 1 commit into
Conversation
Trust modern Fragment.physical_rows before rejecting fragments with no data files, allowing all-null projected columns to synthesize rows after dropping the only physical column. Update fragment validation to use physical_rows for row-bearing fragments without visible data files and cover scan/append regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7236
Fix scans after dropping the only physical column from a dataset that still has row-bearing all-null schema-evolution columns.
Operation::Projectcan leave fragments withfiles = []while retainingphysical_rows. Scans need that row count to synthesize null arrays for the remaining projected columns.Changes
Fragment.physical_rowsbefore rejecting file-less fragments inFileFragment::physical_rows().physical_rowsis present.physical_rowsfor deletion-vector bounds in file-less projected fragments.