fix: record TakeExec output and I/O metrics#7228
Open
skyshineb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #7227. The IoMetrics of the
takeoperator are broken. The metrics such asoutput_bytes=0.0 B,output_batches=0,bytes_read=0are not visible.Example:
... Take: elapsed=350.781983256s, columns="_distance, _rowid, (vec)", metrics=[output_rows=10.00 K, elapsed_compute=302.52s, output_bytes=0.0 B, output_batches=0, batches_processed=1, bytes_read=0, iops=0, requests=0] ...Cause
TakeExecwas recording output row metrics insidemap_batch, before the spawned take work had completed and before the finalRecordBatchwas emitted through DataFusion's metrics path. As a result,output_batches,output_bytes, andScanSchedulerI/O metrics stayed at zero even when take work read data successfully.Solution
This moves metric recording to the post-
try_bufferedresult path, records the finalRecordBatchwithBaselineMetrics::record_poll, and recordsScanSchedulerI/O metrics after the actual take/read workcompletes. The stream also finalizes baseline metrics and records one final I/O snapshot when it finishes.
Added a regression test covering output rows, output batches, output bytes, bytes read, IOPS, requests, and
batches_processed.