Skip to content

feat: release gil during remote storage operations to prevent blocking #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beinan merged 1 commit into from
Jan 28, 2026
Merged

feat: release gil during remote storage operations to prevent blocking #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions python/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ impl Context {
#[pyo3(signature = (uri, *, storage_options=None))]
fn create(
_cls: &Bound<'_, PyType>,
py: Python<'_>,
uri: &str,
storage_options: Option<&Bound<'_, PyDict>>,
) -> PyResult<Self> {
Expand All @@ -80,9 +81,10 @@ impl Context {
storage_options: storage_options_from_dict(storage_options)?,
};

let store = runtime
.block_on(ContextStore::open_with_options(uri, options))
.map_err(to_py_err)?;
let store_res = py.allow_threads(|| {
runtime.block_on(ContextStore::open_with_options(uri, options))
});
let store = store_res.map_err(to_py_err)?;
let run_id = new_run_id();
Ok(Self {
inner: RustContext::new(uri),
Expand Down Expand Up @@ -111,6 +113,7 @@ impl Context {
#[pyo3(signature = (role, content, data_type = None))]
fn add(
&mut self,
py: Python<'_>,
role: &str,
content: &Bound<'_, PyAny>,
data_type: Option<&str>,
Expand Down Expand Up @@ -147,9 +150,11 @@ impl Context {
embedding: None,
};

self.runtime
.block_on(self.store.add(std::slice::from_ref(&record)))
.map_err(to_py_err)?;
let add_res = py.allow_threads(|| {
self.runtime
.block_on(self.store.add(std::slice::from_ref(&record)))
});
add_res.map_err(to_py_err)?;
self.inner.add(role, &inner_content, data_type);
Ok(())
}
Expand All @@ -168,10 +173,9 @@ impl Context {
}
}

fn checkout(&mut self, version_id: u64) -> PyResult<()> {
self.runtime
.block_on(self.store.checkout(version_id))
.map_err(to_py_err)?;
fn checkout(&mut self, py: Python<'_>, version_id: u64) -> PyResult<()> {
let res = py.allow_threads(|| self.runtime.block_on(self.store.checkout(version_id)));
res.map_err(to_py_err)?;
self.run_id = new_run_id();
Ok(())
}
Expand All @@ -183,10 +187,11 @@ impl Context {
query: Vec<f32>,
limit: Option<usize>,
) -> PyResult<Vec<PyObject>> {
let hits = self
.runtime
.block_on(self.store.search(&query, limit))
.map_err(to_py_err)?;
let hits_res = py.allow_threads(|| {
self.runtime
.block_on(self.store.search(&query, limit))
});
let hits = hits_res.map_err(to_py_err)?;
hits.into_iter()
.map(|hit| search_hit_to_py(py, hit))
.collect()
Expand Down
Loading