-
Notifications
You must be signed in to change notification settings - Fork 26
Al2023 builds #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
GeoWill
wants to merge
12
commits into
lambgeo:master
Choose a base branch
from
GeoWill:al2023-builds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Al2023 builds #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically just copy Dockerfile. Use dnf instead of yum. Don't install cmake3 use automake instead of automake16 You can get a nice diff by checking out this commit and running: git diff --no-index --word-diff dockerfiles/Dockerfile dockerfiles/Dockerfile.al2023
This fixes: curl: symbol lookup error: /lib64/libcurl.so.4: undefined symbol: nghttp2_option_set_no_rfc9113_leading_and_trailing_ws_validation
This is for the hdf4 lib
brotli is available systemwide on al2023 so all the packages are linking against it.
based on command gdalwarp is using so file in lib not bin.
docker run --platform=linux/amd64 --entrypoint bash \
--rm ghcr.io/lambgeo/lambda-gdal:3.12-al2023 \
-c "ldd /opt/bin/gdalwarp | grep -i sqlite"
libsqlite3.so.0 => /opt/lib/libsqlite3.so.0 (0x0000752f34cca000)
Bump numpy to 2.x while we're at it.
- Build both Dockerfile (AL2) and Dockerfile.al2023 (AL2023) - AL2 images still use GDAL 3.8.3 - AL2023 images use GDAL 3.11.5 - Drop Python 3.9 support - Add Python 3.14 support - Python 3.10-3.11 runtimes built against AL2 base (GDAL 3.8) - Python 3.12-3.14 runtimes built against AL2023 base (GDAL 3.11) - Separate layer deployment for AL2 (tag: 3.8) and AL2023 (tag: 3.11-al2023) - Update numpy to 2.3.5 for AL2023 Python runtimes
Author
|
Does anyone have any thoughts on this? If not I will probably close it, as I will forget what I did and in any case it will become outdated. No problem if not, I realise everyone is busy. Ping @vincentsarago and @philvarner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this has been a bit stuck, so hopefully this helps move things along.
I don't know if this is the right approach, so feedback is very welcome. At the very least this gets a working build on the al2023 image, building on what @philvarner did in #89.
I don't know if supporting the old al2 images is desirable, but figured they might still be useful, so for the time being this makes the al2023 images alongside them.
I've summarised what I've done, and what I think is left to do, but these might change, as at the moment this leaves the project supporting multiple gdal versions, which I think is a break from how you've done things.
Happy to make changes, or for someone to take what I've done here and repurpose it if it's useful.
Also if there's other QA I can do, that I haven't thought of, then let me know.
What I've done so far:
dockerfiles/Dockerfile.al2023and parametrise the build script./scripts/build.sh 3.11.5 python 3.13 al2023and fix things till it built, and tests (docker run --rm --entrypoint bash -v $(pwd):/local ghcr.io/lambgeo/lambda-gdal:3.11-al2023 /local/tests/tests.sh) passedStill ToDo:
scripts/deploy.pyfor AL2023 supportscripts/list.py